API powering VA.gov
Release 0.0.1448 ami-01280d03d199f6175
6235994 Mobile: Update appointments to use VAOS for local time (#12933)
WIP
Maintain mobile fallback in the event vaos does not return a local time
8da7f8a 59960 Truncate travel claim number to last4 (#12936)
First merge, here we go!
cbb1662 update cron time (#12947)
cb9d9cd Change how we represent UK addresses to BIS (#12911)
Before this PR, if the veteran provided an international_postal_code (i.e. GBR), we used an IsoCountryCodes class to automatically expand that to "United Kingdom of Great Britain and Northern Ireland", which exceeds BIS's 50 character limit for countries by two characters. No other country exceeds the 50 character limit. BIS told me that they use "United Kingdom" for the UK. This PR adds in that exception, along with some minor refactoring.
284253d Move copay notifications back to concurrent approach (#12938)
Move back to concurrent approach...
Decrease to 4 workers
e3bbdbe 5931: lighthouse letters access (#12937)
48726b2 Return nil for strange FT 500 errors (#12948)
return nil for strange FT case
rubocops
06b7066 Revert "API-27078-526-v2-allow-yyyy-mm-date-format-2 (#12927)" (#12949)
This reverts commit ae4f586b4ed6eea181c1990053e11e5dad967f08.
17e3ace Bump oj from 3.14.2 to 3.15.0 (#12916)
Bumps oj from 3.14.2 to 3.15.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
304aad5 Bump aws-sdk-kms from 1.63.0 to 1.66.0 (#12917)
Bumps aws-sdk-kms from 1.63.0 to 1.66.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
881909a Bump kms_encrypted from 1.4.0 to 1.5.0 (#12919)
Bumps kms_encrypted from 1.4.0 to 1.5.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
bc4edad API-27180-add-526-v2-getpdf-endpoint (#12913)
Changes to be committed: modified: modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb modified: modules/claims_api/config/routes.rb
2dc6ac6 Update OAS content claims v1, add swagger (#12943)
9f088aa Bump sidekiq-scheduler from 5.0.2 to 5.0.3 (#12920)
Bumps sidekiq-scheduler from 5.0.2 to 5.0.3.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
cae9321 VA forms: Add form 21P-0847 (#12960)
initially generated files for 21p-0847
add form mappings and tests
rename files
one more name change
refactor multistamp methods and add tests
5e84d5e feat: Lock build to specific debian release (#12962)
feat: Lock build to specific debian release
fix: Update to support docker-compose build
Co-authored-by: Kyle A. Matheny [email protected]
f1724a9 mobile - update claim request decision response (#12952)
a877c2b mobile disability rating EVSS to LH (#12934)
LH disability ratings
specs
specs
specs
remove doc changes
remove error specs
fix
fix
Co-authored-by: Ryan McNeil [email protected]
d557682 Adds flipper feature for evss switch to bgs (#12946)
75e9736 Api 27050 request disability examples (#12931)
Update example.json, fix logic to handle no secondary disabilities case
Add rswag for updated 526 submit example
1fef9b7 Add service description for /veterans/{veteranId}/526 (#12971)
b0716ee Update disabilityActionType enum values, add swagger (#12958)
62acab2 API-22655 526 v2 service description for validate endpoint (#12972)
935fbd2 API-22657 526 v2 service description for attachments (#12973)
4c43ff8 Api 27078 526 v2 allow yyyy mm date format 2 (#12957)
API-27078-526-v2-allow-yyyy-mm-date-format-2
Updates 526.json and related json fles to be inline with new date formats
Updates valdations file to handle new date formats
Updates validation specs t handle tests with new date formats
Updates swagger docs Changes to be committed: modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json modified: modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json
Merges master and updates swagger file to make sure it is inline with these changes
e41fd07 59503 add schedulable param to get_facilities (#12865)
f1d09a5 Api 26640 establish 526 claim (#12907)
Finally got the mapper working mostly - PACT mapping still needs done, but got moved to another ticket
e67f8ec Api 26837/shared schema updates for appeals (#12961)
API-26837 Rename non_blank_string to nonBlankString in appeals
API-26837 Add Content-Language header to appeals
This is suggested in Lighthouse standards
459e31a API-27105: Reinstate Sidekiq Jobs Lost in Periodic Jobs Migration (#12969)
API-27105: Reinstate missing Sidekiq jobs
API-27105: Fix incorrect job schedule for AppealsApi::HigherLevelReviewCleanUpWeekOldPii
API-27105: Update job comment
API-27105: Disable Rubocop BlockLength check
API-27105: Enable Rubocop BlockLength check after disabling
93ece3e removed claims service and configuration files (#12965)
1ed6a25 Api 27356 27357 docs service and logging (#12974)
adds generic logging
return empty supporting docs if errored
update to error for display
dda4a7c re-add concurrent claims index (#12980)
ccdd4b9 Re-enable 1990e confirmation emails to authenticated users (#12970)
be2ac03 Fix periodic job call to VAForms::FormReloader (#12984)
3e2c8b3 Improve BGS validation error logging (#12939)
BGS sometimes returns errors containing an enormous stacktrace with an oracle error. This PR logs the oracle error message and excludes everything else. These oracle errors start with the signature ORA- and are bookended by a prepstmnt clause. See spec/fixtures/bgs/bgs_oracle_error.txt for an example. We want to log these errors separately because the original error message is so long that it obscures its only relevant information and actually breaks Sentry's UI.
b07b477 Bump fastimage from 2.2.6 to 2.2.7 (#12954)
Bumps fastimage from 2.2.6 to 2.2.7.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
efc0222 Bump will_paginate from 3.3.1 to 4.0.0 (#12918)
Bumps will_paginate from 3.3.1 to 4.0.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
3c4004a Bump rswag-specs from 2.8.0 to 2.9.0 (#12955)
Bumps rswag-specs from 2.8.0 to 2.9.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
d0dd386 Bump rspec-rails from 6.0.1 to 6.0.3 (#12956)
Bumps rspec-rails from 6.0.1 to 6.0.3.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
086ca62 Bump carrierwave from 2.2.3 to 2.2.4 (#12976)
Bumps carrierwave from 2.2.3 to 2.2.4.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
c9f860a Handle special characters in names and addresses sent to BGS. (#12968)
BGS doesn't accept name and address_line fields with non-ASCII characters (e.g. , ), and doesn't accept names with apostrophes. The method introduced by this PR recursively iterates through a given hash and strips unprocessable characters from name and address_line fields. The method is called in SubmitForm686cJob and SubmitForm674Job with an enormous form payload potentially containing many names and addresses. See spec/factories/686c/form_686c_674.rb for an example of such a payload.
7466ae2 API-26351 526 v2 schema start/end date alignment (#12982)
Makes date attribute names more consistant throughout the schema. Changes to be committed: modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json modified: modules/claims_api/lib/claims_api/v2/disability_compensation_pdf_mapper.rb modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json modified: modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json
ea807d7 mobile - disability rating update docs and error specs (#12975)
108d98a Mobile: Update endpoint to include feature flag for flipping to lighthouse fo (#12553)
Update endpoint to include feature flag for flipping to lighthouse for direct deposit information
revert accidental changes
Further changes for payment updates
Add spec file
WIP
WIP
WIP
Final progress
Remove old code
Use shared lighthouse auth
Alias method for readability and update naming of memoized variable
Per user flipper
Remove unused payment_account method
Remove unused require
04eeb8c Bump google-protobuf from 3.23.2 to 3.23.3 (#12985)
Bumps google-protobuf from 3.23.2 to 3.23.3.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
0009941 Bump webrick from 1.7.0 to 1.8.1 (#12986)
Bumps webrick from 1.7.0 to 1.8.1.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
6f81a2b Bump jwt from 2.7.0 to 2.7.1 (#12987)
Bumps jwt from 2.7.0 to 2.7.1.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
f4f9154 Bump aws-sdk-s3 from 1.123.1 to 1.124.0 (#12989)
Bumps aws-sdk-s3 from 1.123.1 to 1.124.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
a01113b migration to convert zipcode data type to string (#12978)
migration to convert zipcode data type to string
updated sidekiq jobs and tests for zipcode to string change
revert import and spec
temporarily skip tests
lint
Co-authored-by: Jeremy Weiland [email protected]
767fbf5 add Luke contractor email for flipper UI (#12995)
Co-authored-by: verdanceluke [email protected]
590afba API-26837 Refactor appeals fixtures (#12983)
Moves and copies JSON and PDF fixtures in the appeals_api module so that they are specific to APIs (instead of just to PDF versions).
This is the first of several commits to update all uses of fixture helpers throughout the appeals APIs.
88efbe3 Bump json_schemer from 0.2.24 to 1.0.2 (#12988)
Bumps json_schemer from 0.2.24 to 1.0.2.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
e86a61d API-27427-500-errors-claims-status-v2 (#12994)
Adds safe return with dig
Adds a return of an empty object in the case of a rescue due to EVSS outage
fc514eb Api 27427 500 claims status v2 404 (#12997)
Adds additional fault string to soap error handler
Adjusts error handling to account for LH claim existence
Removes uneeded arg
bfa091e Add error parsing for unhandled responses and update logic (#12998)
1e04dad API-27326 Fixing my overwrites (#13015)
disability_compensation_validation.rb on line 4191deb266 Schedule copay notification jobs in time intervals (#12964)
Schedule jobs using throttle technique
Fix time in comment
spread_interval -> job_interval
Make comment more clear
Add spec for batch processing
Add debt related workers to codeowners
Remove CODEOWNERS change
5cb9a05 modify sidekiq job and tests for string zip codes (#12979)
modify sidekiq job and tests for string zip codes
lint
remove test skips
test update
update zip job
57d54c5 Task update classifier logging (#13013)
update logging message to include the classification
add another log msg w/ submitted_claim_id
Co-authored-by: verdanceluke [email protected]
c260604 remove deceased claimant mappings as per stakeholders (#13017)
a2db1b6 Revert "59503 add schedulable param to get_facilities (#12865)" (#13016)
This reverts commit e41fd0722cd8f2101ca875a8417e5bea28e42d23.
0d8e317 API-26837 Clean up appeals fixture factories (#13001)
4f1aaf8 [59055] Update VHA FSR sidekiq batch callback (#13014)
Make callback method public
Move confirmation email method to user model
Add specs
16e68a6 4747: add get letter as json method to lighthouse letters generator s (#12990)
Release 0.0.1447 ami-0f61c25d162e20474
a8945d1 Move limiter logic to child job for copay notifications (#12932)
Add limiter for batch processing
Adjust limit numbers
Move to concurrent approach
Break out from batch
Decrease concurrent thread count
Revert past decrease
Move throttle to class method
Make static limiter
Lint
Lint pt 2
Restrict copay notifications to 1000/minute
Move throttle to child job
Limit new statement job
Initialize constants after throttle
Move class throttle method to top of class
fb7c24f - remove payment and debt section feature toggle (#12923)
ed97e30 VaNotify - Re-enable 1990 confirmation emails to authenticated users (#12925)
e827b1e [12929] Properly adding idme_uuid as a field when user model is reloaded (#12930)
Co-authored-by: Trevor Bosaw [email protected]
dec516d Update demographics policy to match business rules (#12890)
Update demographics_policy.rb
updated doc wording to be accurate
Update tests to be compatible with updated policy
Copy master index.html to branch
rerender docs
Co-authored-by: Tonksthebear [email protected]
a52cbef update Form526Submission.form w/ classificationCode before submitting to eVSS (#12905)
fix missing request param
log submission id before classification
write update_form_classification() to actually update the form for eVSS
WIP - troubleshooting method not getting called
wip endponit
still WIP testing form update functionality
fix logic for updating form, test against changed outputs
remove comment
fix rubocop issues
remove safeguards for handling legacy vro code
simplify form update function
update spec mock request to resemble current api response
address rubocop
change logging statement to work better w/ datadog
switch to form.to_json
move nil check up
update settings for local vro testing
add additional test case for handling null response
address rubocop issues
address rubocop issue
update spec to reflect latest vro api response
Co-authored-by: verdanceluke [email protected]
33be70b revert cron (#12944)
Release 0.0.1446 ami-0007da11c01e9b4b9
3fe7b94 Restrict copay statement notifications to 1000 / minute (#12924)
Add limiter for batch processing
Adjust limit numbers
Move to concurrent approach
Break out from batch
Decrease concurrent thread count
Revert past decrease
Move throttle to class method
Make static limiter
Lint
Lint pt 2
Restrict copay notifications to 1000/minute
1a3f708 Api 27055 null vet icn v2 526 (#12895)
Add before_action for CCG
Add nil-safing to mpi_record
Add rspec test
Remove byebug
7aba5ed feat(vaos): add get_clinics method to batch retrieve clinic details (#12926)
ae4f586 API-27078-526-v2-allow-yyyy-mm-date-format-2 (#12927)
6f52b3b API-27098: Updates to handling of duplicate UUID response from Central Mail (#12906)
99e0ba3 Add StatsD counters for copay notifications (#12909)
Release 0.0.1445 ami-0e847dfd165d8b451
9bf5b9b Modified letters generator route to be POST and updated tests (#12794)
modified letters generator route to be POST and updated tests
updated letters generator download endpoint to work with POST requests and Benefits Summary options
restored boolean casting and selection in letters generator controller
fixing option filtering
50ba261 VACMS-13184 Remove homepage modal flipper (#12908)
b3d79f4 add feature flipper for form 21-10210 (#12904)
6078929 VAOS: Migrate MFS Clinics Search Call Over to VAOS Service (#12863)
refactor(vaos): update MobileFacilityService to use VAOS Service instead of MFS to get clinic data refactor(vaos): update friendly_name field to use service_name test(vaos): updated VAOS rspec tests work with the changes
test(mobile): update get clinic vcr cassettes due to change from mfs to vaos service endpoints
68f0a0d mobile - lighthouse claims request decision (#12896)
9816aff Bump rswag-ui from 2.8.0 to 2.9.0 (#12883)
Bumps rswag-ui from 2.8.0 to 2.9.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
0d31029 Bump combine_pdf from 1.0.22 to 1.0.23 (#12884)
Bumps combine_pdf from 1.0.22 to 1.0.23.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
a3ca6ec Bump aws-sdk-s3 from 1.119.1 to 1.123.1 (#12885)
Bumps aws-sdk-s3 from 1.119.1 to 1.123.1.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
98fd19f Bump connect_vbms from 43654a0 to 98b1f9f (#12886)
Bumps connect_vbms from 43654a0 to 98b1f9f.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
3b5861d Updating PR template description to negate 'specs run' as an acceptable testing option (#12912)
Co-authored-by: Trevor Bosaw [email protected]
1fb8e34 Bump rails from bc2f390 to 1ae51e3 (#12900)
Bumps rails from bc2f390 to 1ae51e3.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
42922ec Add limiter for copay batch processing (#12910)
Add limiter for batch processing
Adjust limit numbers
Move to concurrent approach
Break out from batch
Decrease concurrent thread count
Revert past decrease
Move throttle to class method
Make static limiter
Lint
Lint pt 2
e9ee241 VAOS Delete Feature Toggle 'va_online_scheduling_convert_utc_to_local' (#12915)
fd2714e API-26837 Reorganize appeals schemas (#12835)
Reorganizes the schemas for forms and headers in the Decision Reviews API and the segmented appeals APIs in a way that makes it clearer which schemas belong to which API
Remove SCHEMA_VERSION constant in appeals API controllers
Minimize FORM_NUMBER constant in appeals API controllers
Adjusts the use of FORM_NUMBER so that it only refers to numbers of
forms (e.g. 200995, 200996, etc.), not names of general schemas
Release 0.0.1444 ami-0ed02826d5b03fd7b
d025b26 Disable FeatureCleanerJob (#12893)
c0b181c 58559 - Add a rake task to generate stats about recent unsubmitted FSR forms (#12832)
add a rake task to generate stats about recent unsubmitted FSR forms
conform to linting
broaden usecase for added scope
ad550b8 flipper for injected header web component work (#12887)
582c013 5708 vet360 linking (#12866)
94ae98a changes user.fingerprint to request.remote_ip for better accuracy (#12878)
87d02f2 Mobile: Create new Secure Messaging Threads endpoint (#12851)
Create new endpoint
Rubocop
Update documentation and add new error response
Update parameter name to what front end uses
Update spec to new directory structure
Reference correct 200 schema
Update spec to check specific return
Remove required from parameters that aren't required
Update documentation description
8138ceb Bump rubocop-thread_safety from 0.4.4 to 0.5.1 (#12870)
Bumps rubocop-thread_safety from 0.4.4 to 0.5.1.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected]
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
bc49d0e add mobile QA engineers to flipper config (#12894)
959a034 Show GUID as part of alert message on slow moving UploadSubmission statuses (#12881)
32de1a0 Replace sidekiq scheduled jobs with periodic jobs (#12825)
Release 0.0.1443 ami-0f69ff17323f5aa49
0cecb24 API-26923 Update description wording for appeals APIs (#12850)
3a80303 Add 5103 endpoint to benefits_claims controller (#12862)
16c3b8b Add VANotify to flipper admin (#12868)
8a448d1 Bump pg from 1.4.6 to 1.5.3 (#12871)
Bumps pg from 1.4.6 to 1.5.3.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
57265d8 Bump yard from 0.9.28 to 0.9.34 (#12872)
Bumps yard from 0.9.28 to 0.9.34.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
d50832a Bump aws-sdk-sns from 1.60.0 to 1.61.0 (#12873)
Bumps aws-sdk-sns from 1.60.0 to 1.61.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
ff9a784 Bump sidekiq_alive from 2.2.1 to 2.2.2 (#12874)
Bumps sidekiq_alive from 2.2.1 to 2.2.2.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
3220939 Api 24835 526 v2 section 8 direct deposit information validation (#12818)
RSpec stes written and validation methods added, waiting on some feedback on questions to continue
Updates schema for discussion in stand up
Updates and validation, leaving in place until standup discussion
Adds direct deposit validation - section 8 API-24835
Adds validataion for direct deposit elements
Updates 526.json schema file and related files to ensure correct validations
Updates rswag docs with update schema
Adds RSpec tests for validations Changes to be committed: modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json
Fixing my Gemfile.lock include
Rollbacks incorrect inclusions when fixing merge conflict
Merges master, tests running green, ran swager compile
Refactors validation file, strengthens tests up
Fixes strings being passed into the error raised
Updates test value so it matches a valid account number
Fixes account number REGEX after latest merge test was red, tests green and in original state,updates swagger and all related json files
Refactoring in validation file to make check more rebust and give better name to deposit error method
0203beb API-27053 526v2 currentVAEmployee not required and defaults to false (#12856)
3f76843 API-26148-526-v2-pdf-gen-setup (#12663)
Adds to setting files the url for the pdf gen
REmoves unneeded changes, and changes the settings path to dvp
Removes line changes
Removes line changes
Changes location of evss service name
Changes location of variables after discussion
Adds dvp url to settings file
Corrects values to match config map in the vsp-infra-application-manifests repo.
Removes reference
f562975 API-26966-526-v2-req-body-updates & API-27054 (#12824)
Changes values in example, request body, form_526, and schema based on PM feedback.
Adjusts example to match form_526
Matches example.json to form_526_json_api.json to eliminate validation errors.
Adds verify access to ticket 27054, and swagger update.
Adjusts tests to accomodate ccg flow.
Adds catch for missing treatment section.
Adds swagger after testing with Postman; and adding tasks to new cleanup ticket.
Fixes test
Fixes test
178ba05 Add mapping and spec test (#12837)
78121ff its honest work (#12879)
f2581ef API-24836-526-v2-sec-9-map-signature (#12834)
Adds test for signature in request spec.
Rubocop
Release 0.0.1442 ami-0e93e36dadc8604fe
e9abb7c 4195 beneficiary endpoint fix (#12846)
fixed naming in beneficiary to match old schema
updated specs
fixed order changes to match docs
e8564ad move mobile cassettes to root spec folder (#12847)
move mobile cassettes to root
lint fix
58c2fa3 Removing metadata flag (#12857)
df0ff7d API-26689: VBADocuments Data Migration to Remove doc_type from UploadSubmission Records (Take 2) (#12864)
API-26689: Update 'doc_type' removal data migration to perform updates in batches of 1_000
API-26689: Skip rubocop requirement for use of 'update_all'
API-26689: Move rubocop enable statement for clarity
d63f227 Config change to add Randi Mays for Flipper Admin (#12867)
06d8fbf [#951] Refactor the Virtual Agent JWT fetch code to use a helper class. (#12859)
[#951] Refactor the Virtual Agent JWT fetch code to use a helper class. [department-of-veterans-affairs/va-virtual-agent#951]
Co-authored-by: Maurice Okumu [email protected]
We refactored the code to allow for the extending of the common::client::base
f67ff7b Bump fakeredis from 0.8.0 to 0.9.2 (#12829)
Bumps fakeredis from 0.8.0 to 0.9.2.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
9c0b63c Remove profile_use_vaos_v2_api feature flag (#12750)
20c0d3b Bump google-protobuf from 3.23.1 to 3.23.2 (#12852)
Bumps google-protobuf from 3.23.1 to 3.23.2.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
cc7ad32 Bump nokogiri from 1.14.3 to 1.15.2 (#12853)
Bumps nokogiri from 1.14.3 to 1.15.2.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
86e337a Bump faker from 3.1.1 to 3.2.0 (#12854)
Bumps faker from 3.1.1 to 3.2.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
b077940 Bump pg_query from 4.2.0 to 4.2.1 (#12855)
Bumps pg_query from 4.2.0 to 4.2.1.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
Release 0.0.1441 ami-0d08462ba50fdf000
873f9fb API-26761 Optimize VBADocuments::UploadRemover job (#12839)
Updates SQL in the job to hopefully reduce execution time
15d696c update with new pdf (#12842)
04d681e [#951] create new route for Virtual Agent JWT proof of concept (#12844)
original issue 951 Co-authored-by: Maurice Okumu [email protected]
2e5fc61 Direct deposit update (#12812)
Add update function to direct deposit service and standardize error responses
Linting fixes
Co-authored-by: Jeremy Weiland [email protected]
7ec7ae1 56197 Filter Out Service Type(s) on Non-health Non-CnP Appointments (#12845)
feat(vaos): remove service types for non-medical for non-medical non-CnP non-cc appointments
test(vaos): fixed rspec tests that would intermittently fail
8bb4baa 58400 appointment details comment logging (#12848)
26a79b4 Bump rack-test from 1.1.0 to 2.1.0 (#12715)
Bumps rack-test from 1.1.0 to 2.1.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected]
fix capitalization issue with rack-test
add case for empty string (rack-test)
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
8ec8183 Bump rails_semantic_logger from 4.11.0 to 4.12.0 (#12816)
Bumps rails_semantic_logger from 4.11.0 to 4.12.0.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected]
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
eb4eada remove concurrent processes on claims (#12849)
8d6add6 Maps direct deposit info for the pdf generator. (#12792)
470d2f0 Bump ox from 2.14.14 to 2.14.16 (#12828)
Bumps ox from 2.14.14 to 2.14.16.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2185e7e Bump rack from 2.2.6.4 to 2.2.7 (#12830)
Bumps rack from 2.2.6.4 to 2.2.7.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
b49c503 Adds feature flag for August release (#12838)
589af8f Api 24833 526 v2 section 6 service info validation part 2 v2 (#12790)
Service Information validation - Part 1 API-24833 - Part 1 AC points 9 - 21
Adds RSpec tests for validating service information elements for AC points 9 - 21
Adds methods in validation file for validating service information elements
Updates 526 schema, and related JSON files, with unitPhone regex patterns and updated example with alternate name values Changes to be committed: modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json
Service Information validation - Part 2 API-24833 - Part 1 AC points 10 - 21 Alters the AC points covered, now part 2 covers 10 - 21 and adjusts RSpec and validation file in line with that. Changes to be committed: modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
Making sure to update swagger dev file with any merges
Merges master and fixes tests
Removes ensured newline at save that was added into 526_json_api file
2dd990e API 24828 v2 526 address validation (#12795)
Validate Change Of Address
Fix typo
Fix tests
Co-authored-by: Austin Covrig [email protected]
207be63 824 create 22 1995 confirmation email trigger (#12514)
Release 0.0.1440 ami-058986fdc42d33d93
942eb97 Remove skipDimensionCheck benefits intake key (#12827)
Removes the metadata key skipDimensionCheck from the Benefits Intake
API, which allowed uploads with no check on page dimensions. This was a
temporary and undocumented feature.
aa6c8d3 Create two endpoints for startupProbe and readinessProbes (#12836)
6fde0c3 Api 24834 section 7 service pay validation (#12771)
Incremental commit
Rubocop fixes
Test fixes & cleanup
Disable module length check
Update context descriptions for updated field names
Linting fix for quotes
Remove duplicate module declaration
Changes for review feedback
Add generated swagger
77207bb API-26689: VBADocuments Data Migration to Remove doc_type from UploadSubmission Records (#12843)
API-26689: Add rake task for removing doc_type from UploadSubmission metadata
API-26689: Updating namespacing of rake tasks
API-26689: Fix indentation
c589b29 API-26273-526-v2-sec-6-serv-info-pdf-gen (#12748)
WIP - adds serv info to pdf mapping
Adds service info mapping
Changes schema; removes confinement from confinements
foramtted schema
rubocop
Adds unitAddress and confinement changes back to schema and form_526
Adds back the unitAddress to request and example.json
Changes confinement dates to be more realistic
Addresses PR comments
cb632a7 Revert "API-26059 Log durations of some sidekiq jobs (#12474)" (#12840)
This reverts commit 2a0bead3f34c8175c1a60dbc80cd5441d21c62d3.
a9ac9cb Api 24831 section 5 disabilities validation (#12749)
Incremental commit
Fix secondary disability logic
Add validation for diagnostic code & toxic exposure
Commit working implementation
Add VCR cassette for BRD disabilties, add & update disability tests
Add rspec tests for secondary disabilities
Rubocop fixes
Disable module length check
Fix tests broken by merge
Move name validation to schema, update tests
Updates to fix rspec tests, accomodate schema change
Misc cleanup
Fix pdf mapper tests
Fix tests after merge w/ master
Test updates to add VCR cassette
Co-authored-by: Jeremy Weiland [email protected]
80f5e1b add flipper for form 21-4142 (#12841)
7c0e173 Adds country transform (#12801)
Release 0.0.1439 ami-0b6bfcbfd76f81899
9c2cea3 Mobile: Update demographics policy and update all associated controllers and (#12813)
Update demographics policy and update all associated controllers and service to use policy
Rubocop
Make swagger test pass
e51084b Mobile LH claims - contention list field fix (#12807)
b1ec211 Bump google-protobuf from 3.22.2 to 3.23.1 (#12716)
Bumps google-protobuf from 3.22.2 to 3.23.1.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
b103958 [58320] Exposing sign in service public key for access token decoding (#12814)
Co-authored-by: Trevor Bosaw [email protected]
fefebbe Bump statsd-instrument from 3.5.6 to 3.5.9 (#12815)
Bumps statsd-instrument from 3.5.6 to 3.5.9.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
8c1069d Bump puma from 6.1.1 to 6.2.2 (#12817)
Bumps puma from 6.1.1 to 6.2.2.
updated-dependencies:
Signed-off-by: dependabot[bot] [email protected] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil [email protected]
1382465 set tag with form_id on active traces (#12823)
9bd9358 Hotfix to allow edit action even if user can't update (#12826)
d7192ab Bdex/57064 migrate post intent to file to lighthouse (#12753)
implement GET request for Lighthouse intent-to-file
modify BenefitsClaims::Service to request intent to file data
extend BenefitsService::Configuration to handle different consumer/client needs
modify existing BenefitsClaims index and show operations to handle new configuration
implement GET request for Lighthouse intent-to-file
modify BenefitsClaims::Service to request intent to file data
extend BenefitsService::Configuration to handle different consumer/client needs
modify existing BenefitsClaims index and show operations to handle new configuration
add parameters to fix evss method, move transform to private method, rm unneeded comment
add error handling and request specs
fix a few request specs
fix some tests to accommodate provider pattern
fix rubocop errors, add tests to lighthouse itf provider
Merge branch 'bdex/57063/migrate-get-intent_to_file-to-lighthouse' of https://github.com/department-of-veterans-affairs/vets-api into bdex/57063/migrate-get-intent_to_file-to-lighthouse
Implement service ITF post
Add TODO for swagger spec
implement GET request for Lighthouse intent-to-file
modify BenefitsClaims::Service to request intent to file data
extend BenefitsService::Configuration to handle different consumer/client needs
modify existing BenefitsClaims index and show operations to handle new configuration
add parameters to fix evss method, move transform to private method, rm unneeded comment
add error handling and request specs
fix a few request specs
fix some tests to accommodate provider pattern
fix rubocop errors, add tests to lighthouse itf provider
a little cleanup, fixing errors in lighthouse service, config, and spec
Revert "Add TODO for swagger spec"
This reverts commit ca98b3c32c9c3a3be7520039c89f4cd7f3494b78.
minor tweak for Rubocop and require needed files
Correct stomped swagger_spec
Remove committed debug statements; Update TODOs to be more indexable
Update parameters of evss provider
Add template automated tests
Correct improper identifier in EVSS ITF provider
Correct LH provider parameters and tests
Update evss itf spec
Update LH ITF specs; Attempt VCR continuous integration; Add mock responses
Remove some TODOs
Add missing param to service spec
Some cleanup and missed comments
Change create to supply ssn on function call instead of initialize; Simpliy current_user interface
Regenerate VCR cassettes
Add some future TODO considerations; Fix expects to match data structure
Fix missed parameter update
Linting auto-fixes
Revert changes to benefits_claims_controller
Commit removing credentials from intent_to_files_controller
Remove missed comments and unused var assignment
Co-authored-by: Eddie Glenn [email protected]
d47ce64 remove unused mobile code (#12822)
Only removing unused code. Large diff acceptable.
8ba8416 change span to trace to put tag at highest level (#12831)
4305394 updates production swagger for sandbox docs (#12803)
21769b3 Api 24833 526 v2 section 6 service info validation part 1 v2 (#12789)
Service Information validation - Part 1 API-24833 - Part 1 AC points 1 - 12
Adds RSpec tests for validating service information elements for AC points 1 - 12
Adds methods in validation file for validating service information elements
Updates 526 schema, and related JSON files, for the updated type for confinements Changes to be committed: modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json
Service Information validation - Part 1 API-24833 - Part 1 AC points 1 - 12 Alters the AC points covered, now part 1 covers 1 - 9 and adjusts RSpec and validation file in line with that. Changes to be committed: modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
Removes RSpec tests that moved over to part 2
Fixes my misunderstood structure for confinements
Removes a log out and gets the brakeman update