Otservbr Global Versions Save

Fix cmake warning (wrong boost dir on library) (https://github.com/opentibiabr/canary/pull/362, https://github.com/opentibiabr/canary/commit/d2279bf, @dudantas)
Resolves the issue of killing some monsters giving error on distro (https://github.com/opentibiabr/canary/pull/370, https://github.com/opentibiabr/canary/commit/8686cd9, @dudantas)
Fix typo on daily reward, from addItemId to addU16 (https://github.com/opentibiabr/canary/pull/371, https://github.com/opentibiabr/canary/commit/9da46a7, @dudantas)
Fix item name register from appearances protobuf (https://github.com/opentibiabr/canary/pull/376, https://github.com/opentibiabr/canary/commit/a4073d7, @marcosvf132) It was missing the item name register on the function void Items::loadFromProtobuf() on the Items map. This map is used to identify a item by it's name instead of ID. This is largely used on the SRC and LUA environments.
Fix removing unnecessary warn on item creation when id equal 0 (https://github.com/opentibiabr/canary/pull/368, https://github.com/opentibiabr/canary/commit/48ab545, @marcosvf132) Add a check on the SPDLOG::WARN to prevent when itemID is equal 0. This happens a lot when slain a creature that has no body registered. (Regular creatures/summons/boss)
Fix protobuf error on server loading (https://github.com/opentibiabr/canary/pull/380, https://github.com/opentibiabr/canary/commit/5ad63c1, @beatsdh and @marcosvf132) Change all 'strings' to 'bytes' This wrong behavior on the items name register was affecting only items who had their names on the appearances.dat protobuf file but was not registered on the items.xml file
Fix magic wall and wild growth rune bug (https://github.com/opentibiabr/canary/pull/388, https://github.com/opentibiabr/canary/commit/f5fb255, @dudantas) Created a new function to set the min/max duration of an item, id to decay and whether or not to show the duration Fixed mw being walkable, fixing a small typo in blocking parse Usage of setDuration: item:setDuration(minduration, maxduration = 0, decayid = 0, showDuration = true)
Fixed bug summon not searching player target and icons update (https://github.com/opentibiabr/canary/pull/395, https://github.com/opentibiabr/canary/commit/6b56fbf, @dudantas) Fixed the bug when the player was attacking a creature and summoned, the summon would not attack the creature until the player stopped attacking and attacked again Fixed the icon of creatures that use the "creature:addSummon" function Added Game::reloadCreature functions Rework on function "Creature::setMaster", somes functions were centralized within the setMaster, avoiding repetitions: Creature::setTarget Creature::setFollowCreature Creature::setDropLoot Creature::setSkillLoss
Fix non-unique item name registration (https://github.com/opentibiabr/canary/pull/390, https://github.com/opentibiabr/canary/commit/63b30ca, @marcosvf132) Fix an issue related to items that have a non-unique name on the register. This problem was breaking some monster's loot.
Fix unexpected behavior on connection send and disconnect (https://github.com/opentibiabr/canary/pull/408, https://github.com/opentibiabr/canary/commit/4f1dbaf, @dudantas) Added nullptr check for validate connection Renamed protocol variable from connection to connectionPtr to avoid shadowing with the other connection variable added to check nullptr
Fix magic wall and wild growth on retro-pvp and no-pvp logic (https://github.com/opentibiabr/canary/pull/400, https://github.com/opentibiabr/canary/commit/dc5c868, @dudantas) The magic wall/wild growth rune should only be removed when stepping if it's no-pvp and if it's not blocking
Few prey/task hunting fixes and improvements (https://github.com/opentibiabr/canary/pull/385, https://github.com/opentibiabr/canary/commit/b1786d5, @marcosvf132)
Fix null function on daily reward (https://github.com/opentibiabr/canary/pull/375, https://github.com/opentibiabr/canary/commit/1960d49, @dudantas) Resolves https://github.com/opentibiabr/canary/issues/374
Fix "nil item" on daily reward (https://github.com/opentibiabr/canary/pull/423, https://github.com/opentibiabr/canary/commit/0b65754, @dudantas) Resolves https://github.com/opentibiabr/canary/issues/421
Fix checks on player death, player speed breakpoint and misc enhancements (https://github.com/opentibiabr/canary/pull/378, https://github.com/opentibiabr/canary/commit/e5cc80a, @omeranha) Added tag in config.lua for: Max critical chance of imbuements Adventurers blessing level Inventory glow on five bless Fixes Set default maxSpeed for 70000 Still blessed after dead for work with "no disconnect on death" Player targetting after dead for work with "no disconnect on death" Adventurer blessing logic for work with "no disconnect on death"
Fix some npcs bugs and change behaviour (https://github.com/opentibiabr/canary/pull/396, https://github.com/opentibiabr/canary/commit/5b25b43, @dudantas) Total cost for custom currencys Bank npcs depot, transfer and withdraw logic Changed: MsgContains behaviour, added new function "MsgFind" so that we avoid some bugs in messages that have the same words Added debug log for assistant with debug build
Fix Callback fromPosition of some lua scripts that were registered by position (https://github.com/opentibiabr/canary/pull/441, https://github.com/opentibiabr/canary/commit/723f378, @dudantas) Some scripts registered through position didn't work the fromPosition callback because it was lost between the two functions (with and without the callback item)
Fix build of docker and linux (https://github.com/opentibiabr/canary/pull/440, https://github.com/opentibiabr/canary/commit/90e7561, @beats-dh) Fixed the compilation in the docker environment and the error that occurred with linux when it was going to compile on a new "VM" machine. What happened is that the protobuf was updated and our proto files were generated in an old version, with this change they are ready to work with the latest version of the protobuf made available by vcpkg Note: vcpkg needs to be updated to the most current version for it to work properly
[CMake] fix warning build, add flag /EHsc to target compile options (https://github.com/opentibiabr/canary/pull/442, https://github.com/opentibiabr/canary/commit/afab2af, @beats-dh)
Fix remove summon bug and added new config tag for teleport summon (https://github.com/opentibiabr/canary/pull/428, https://github.com/opentibiabr/canary/commit/5bd86e6, @beats-dh) Added new config.lua tag: teleportSummons = false Usage: if false, the summon will not teleport when the player goes up/down stairs and moves far away, if true, it will teleport the summon Fixed the bug that did not remove the summon when the player leaves the summon range, thus preventing the player from summoning a new monster
[Fix] Bestiary unlocked creature (https://github.com/opentibiabr/canary/pull/438, https://github.com/opentibiabr/canary/commit/e033f83, @beats-dh)
[Fix] convert burst and poison arrow to client id (https://github.com/opentibiabr/canary/pull/405, 647b005, @Aerwix)

Features/Enhancements

Some small improvements to gha (https://github.com/opentibiabr/canary/pull/363, https://github.com/opentibiabr/canary/commit/44c8e82, @costallat) Improves the GHA overall performance Disable ccache for Windows as it doesn't work Add sscache for Windows Adjust some cmake flags to work with sscache
Rework and fix event scheduler (https://github.com/opentibiabr/canary/pull/239, https://github.com/opentibiabr/canary/commit/526ef51, @beats-dh)
[CrashFix] fix monster type name overriding and some improvements (https://github.com/opentibiabr/canary/pull/389, https://github.com/opentibiabr/canary/commit/86e4a90 @dudantas) The real name of the monster was replaced by the name of the look, generating unexpected behavior and in a very specific scenario a crash (when two different monsters had the same "name") Some improvements related to the creation of monsters and the verification of the monster name in getMonsterType, also preventing any unexpected behavior New function: Creature::getTypeName(), for get real monster type name
Rework in MoveEvent and MoveEvents class for fix memory leak (https://github.com/opentibiabr/canary/pull/398, https://github.com/opentibiabr/canary/commit/4771913, @dudantas) Movements completely redone to remove a memory leak related to the registration of movements, in the luaMoveEventRegister function, where the memory was fread and then used. We also added some pointer sanity checks, preventing future crashes and fixing some known ones. Removed old XML load Passed some objects as a reference, to avoid nullpointer and unecessary pointer checks Added nullpointer checks in some places and the code was redone to work better Added some logs to help in case of errors Fixed crash related to replaceable magic fields Notes: MoveEvent::onRemoveItem function from now on it will no longer have the "tileitem" argument
[Enhancement] Changed rsa to use gmp lib instead of cryptopp (https://github.com/opentibiabr/canary/pull/391, https://github.com/opentibiabr/canary/commit/b0538c4, @beats-dh and @dudantas) Thanks and credits to @saiyansking for the original code This pull request has modifications from the optimized forgottenserver: https://github.com/opentibiabr/optimized_forgottenserver Added function in otserv.cpp to load default RSA key if it fails to load key.pem Rework on connection.cpp and improvement of some functions Removed some "reinterpret_cast", added in place "static_cast" which avoid overflows or undefined behavior Improved connection and protocol code for QT client
Change luajit to install by vcpkg manifest (https://github.com/opentibiabr/canary/pull/403, https://github.com/opentibiabr/canary/commit/5fc2834, @dudantas) Remove appveyor build Remove build windows 2019 and ubuntu 18 Added ubuntu 22.04 build
Improve monster loot log (https://github.com/opentibiabr/canary/pull/372, https://github.com/opentibiabr/canary/commit/116cc9e, @dudantas)
Disabled install LuaJit for processor ARM (https://github.com/opentibiabr/canary/pull/416, https://github.com/opentibiabr/canary/commit/6ad0268, @beats-dh) Disabled installation of LuaJit by vcpkg.json, solving the problem of compatibility with ARM processors. The installation of LuaJit will have to be done by apt Linux with the command: sudo apt install libluajit-5.1-dev
[Enhancement] Set teleport position talkaction for use in all teleport types (https://github.com/opentibiabr/canary/commit/b996fbe, @dudantas)
[Enhancement] - Automatically download world otbm in folder if file doesn't exist on server start (https://github.com/opentibiabr/canary/pull/437, https://github.com/opentibiabr/canary/commit/5e42475, @omeranha) If toggleDownloadMap if false, then the mapDownloadUrl will not be used If a map with the name already exists in the world folder, the map will not be downloaded even if the toggleDownloadMap is true
[Feature/Enhancement] - New objects; Lever, Spawn and Spectators to assistant with boss/quest scripts and others (https://github.com/opentibiabr/canary/pull/360, https://github.com/opentibiabr/canary/commit/0d9d3a1, @Glatharth) The new objects will help us with boss scripts, quests, and spectator checks, reducing the complexity and size of a lot of code. Added an example of how the mechanics work in the lever of threatened dreams quest.
[Feature] Depot search system (https://github.com/opentibiabr/canary/pull/411, https://github.com/opentibiabr/canary/commit/a02d5a5, @marcosvf132) Enabling and implementing client 12x feature named 'Depot search'. This system can be used to make it easier to find, organize and manipulate players depot/inbox/stash. The systems already include support for a future implementation of item tier system. The tier system is being implemented on PR #366

New Lua functions

item:setDuration(minduration, maxduration = 0, decayid = 0, showDuration = true)

GitHub

Enable cache for sonarcloud (https://github.com/opentibiabr/canary/commit/33dff84, @costallat) It's disable by default now so we need to enable it

Closed issues:

https://github.com/opentibiabr/canary/issues/374, https://github.com/opentibiabr/canary/issues/#421

patch-v1.3.1

2 years ago

Release version: Stable v1.3.1 (Patch) - e06dd7ff

Download Tibia Client 12.86.11871

Download OTClient 1.0, thanks for @mehah

Fixes

Crash related to creature death (@dudantas, https://github.com/opentibiabr/canary/commit/03e8e09e) The crash happened in a specific scenario, when the creature was removed (and recreated) and the target reference was not removed, when it tried to target another creature, it crashed.
Market issue related to stash items and gold duplication (@marcosvf132, https://github.com/opentibiabr/canary/commit/7082aff3) There is an issue on the market that was making the item remove count 0 when accepting buy offer. Issue reported by @Sparkz023

Changes from Major Release version: stable 1.3.0

Commits: c7857525, https://github.com/opentibiabr/canary/commit/80908fd4

Canary:

Features/Enhancements

Complete rework on npcs shop add item functions (@dudantas, https://github.com/opentibiabr/canary/commit/caf0a970)
Experience tracker (@marcosvf132, https://github.com/opentibiabr/canary/commit/990da240) On the oldest protocols, the client was handling the experience changes by it's own, now on the new protorocol (12.72+), we need to send to the client the right amount of experience that the player has gainned so it can update it's tracker
Auto Loot, Quick Looting in stack and Auto Bank function (@omeranha, https://github.com/opentibiabr/canary/commit/5cb9ff7b) Auto loot using your manage loot containers quick loot categories and items filter, can be enabled in config.lua! Quick loot in stack, up to 30 corpses, enabled using client option. Auto Bank function, the dropped coins from monsters will be automatically deposited to your bank account, can be enabled in config.lua.
No disconnect on death (@omeranha, https://github.com/opentibiabr/canary/commit/4f8667a6) no more disconnection when player dies
Solved incompatibility problem with otclient redemption (@marcosvf132, https://github.com/opentibiabr/canary/commit/c46f64d2) Readjust protocolgame to follow the right pattern. Changing hardcoded expected bytes on OnRecvFirstMessage to follow the cip client and fix incompatible with otclient protocolgamesend.
Decouple g_game in true singleton (@dudantas, @lgrossi, https://github.com/opentibiabr/canary/commit/126e7df) Game class decoupled in a true singleton, thus allowing direct calls without needing to instantiate in each file. Credits to @lgrossi for made the decouple logic.
Fix build to not use asan on relase mode (@costallat, https://github.com/opentibiabr/canary/commit/87edf62) Not use ASAN for release build Remove cmake settings(replaced with presets) Adjust GitHub Actions triggers
Cmake features and update workflows to use gcc 11 (@dudantas, https://github.com/opentibiabr/canary/commit/905f774) Update sonarcloud version and sonar/codeql/ubuntu build to use gcc 11 Added gcc minimum version 8 in cmakelists.txt Reorganized find_packages Fix possible bug in the spdlog link library
Add tag serverSaveTime on config.lua (@beats-dh, https://github.com/opentibiabr/canary/commit/e848604) With this modification, the configuration of the global server save can be done directly in config.lua, thus centralizing configurable things in a single place
Add missing librarys; daily reward, modal windows and reward boss (@dudantas, https://github.com/opentibiabr/canary/commit/c45f1d2) Added somes missing librarys: daily reward, modal window, reward boss Added new scripts for: monsters and spells
Party hunt analyzer. (@marcosvf132, https://github.com/opentibiabr/canary/commit/c17279a) Adding the "new" feature Party Hunt Analyzer. There is one thing that you must know before you start testing it, so please read the entire PR commentary.
Added not moveable action function (@dudantas, https://github.com/opentibiabr/canary/commit/9c49c95) Not moveable action id = 100 So that the item cannot be moved, just put this action id in the item
Add windows relelease build with address sanitizer (@costallat, https://github.com/opentibiabr/canary/commit/8552c10) Adds new release build with asan enabled to help tracking problems
Added missing effects from version 12: soulwar/tentugly/supreme cube (@aerwix, https://github.com/opentibiabr/canary/commit/371f116)
Added a new method to register scripts by the map position and rework on "registerLuaEvent" function (@dudantas, https://github.com/opentibiabr/canary/commit/a7e6426) See all description on the commit With this modification, we can register action scripts without needing the action id/unique id or the item being on the map, as there is also a second parameter that creates the item (if it doesn't exist).
Decouple all global variables from extern in true singleton (@beats-dh, @lgrossi, https://github.com/opentibiabr/canary/commit/b87372f) All the global variables * g_* were decoupled to true singletons, reducing the dependencies between the objects and simplifying the amount of calls and instances. They used to be partial singletons mixed with global variables, that way we have one, and only one instance that is accessed via the getInstance methods, that are now the * g_* functions.
Prey system rework (CPP) + Hunting task system (@marcosvf132, https://github.com/opentibiabr/canary/commit/42af88d) Complete rewrite of old prey system from LUA to CPP and implementation of Hunting Tasks system; Do not test with GOD char or with low amount of creatures registered on bestiary. The PR already include the necessary amount of then; Addition of hunting task system and entire rework of prey system. All working on CPP with few LUA integration.
Check for message type parameter wrong (@dudantas, https://github.com/opentibiabr/canary/commit/ea7fbce) How to test: Add a message with a wrong or none parameter, such as: player:sendTextMessage(MESSAGE_WRONG, "Message")
Rework on fluids colors and new monster race type (INK) (@marcosvf132, https://github.com/opentibiabr/canary/commit/ce36520) Description Full rework on the way that the server handles the fluids, to use one single ENUM and remove all the garbage functions and maps that used to store the same values for fluids over and over again. Add new creature race type named INK. This new race type is used mostly on creatures on the tibia "The Secret Library". Attacking those creatures or slain then will now create the proper type of blood pool/splash. Resolves https://github.com/opentibiabr/canary/issues/123 OTServerBr-Global PR: https://github.com/opentibiabr/otservbr-global/pull/544
Add script casks and kegs (store item for refill potions) (@lucasgrizante, https://github.com/opentibiabr/canary/commit/256a6ee)
Move client version from config.lua to definitions.h (@dudantas, https://github.com/opentibiabr/canary/commit/4580324c) It's a tag that works at the compilation level and shouldn't be in config.lua, because the version is always just one and cannot be modified at the configuration level.
Rework on items to extinquish OTB file and use client 12 protobuf instead (@marcosvf132, https://github.com/opentibiabr/canary/commit/68d0475c) See the commit description for more information

New Lua functions

Added container:getItems() function and option stash moving items to supply stash and depot (@omeranha, https://github.com/opentibiabr/canary/commit/844530b7)

Fix

Register Npc Type - add missing currency method for npcs revscriptsys (@aerwix, https://github.com/opentibiabr/canary/commit/9f37c02a)
Bestiary tracker list loader (@marcosvf132, https://github.com/opentibiabr/canary/commit/9a02596f)
Reverting item tier to 0 + Market/Cyclopedia item tier (@marcosvf132, https://github.com/opentibiabr/canary/commit/4c7a35a3)
Life and mana leech amount/chance attribute (@guispiller, https://github.com/opentibiabr/canary/commit/56ddcf2f) Fix to correct the item tags of mana leech and life leech items attributes. Extra: added attributes missing on some soulwar weapons.
"allowpickupable" tag on items.xml, resolves trashholder items (@dudantas, https://github.com/opentibiabr/canary/commit/e3df5835)
Ring transformation on creation (@marcosvf132, https://github.com/opentibiabr/canary/commit/0eacb35b) Rings was transforming into wrong itemIDs on creation.
Add missing duration timestamp attribute for decay system (@beats-dh, https://github.com/opentibiabr/canary/commit/15275499)
logout message connection lost on bed and offline training and remove unused tag on druid familiar (@omeranha, https://github.com/opentibiabr/canary/commit/e6abcc8f) Fixes connection lost message when using an bed or offline training statues, added a check to identify when a player was "forced" removed
Auto Bank not removing coins from monster corpse (@omeranha, https://github.com/opentibiabr/canary/commit/0059314e)
docker-compose: add env to correct mysql host (@bruno-costa, https://github.com/opentibiabr/canary/commit/611a44ef)
Few hireling issues (@marcosvf132, https://github.com/opentibiabr/canary/commit/3808591d) Fix hireling outfit change client crash. Fix hireling server crash when saying 'hi - lamp - yes'. Convert hireling itemids from serverID to clientID.
'wound' bestiary charm register (@marcosvf132, https://github.com/opentibiabr/canary/commit/deeb21ff) Wound bestiary charm was not showing on the cyclopedia charm store due to one miss config on the Lua file.
Multiple purchase of the same mount from store. (@corlyone, https://github.com/opentibiabr/canary/commit/3e94dc2b) When buying a mount, it was possible to buy it indefinitely, causing the player to lose coins.
Not be able to accept offer if you are a character on the same account (@dudantas, https://github.com/opentibiabr/canary/commit/65b53485) Fix for player selling offer not receiving money if offline (thanks and credits for @gccris) Added verification to prevent transactions with characters of the same account
[Fx] Rework of checkCreatureAsKnown and fix of client debug (@beats-dh, @lgrossi, https://github.com/opentibiabr/canary/commit/77f152e3) Before, if you moved with the char diagonally for a while or even normally at a certain time, the debug client "closes unexpectedly" with this fix it doesn't happen anymore. Note: walking diagonally forces the client to debug faster. Credits fix code: @mrianura
crash on buy own offer in market (@dudantas, https://github.com/opentibiabr/canary/commit/d488fae) Removed some unnecessary delete pointers
Added check to ensure the item is not imbued twice with the same imbuement (@dudantas, https://github.com/opentibiabr/canary/commit/dd03479)
Add decayImbuementTime function for use of updateInventoryImbuement (@dudantas, https://github.com/opentibiabr/canary/commit/8559f3c) Function to avoid sending the message "imbuement already exists" when equipping/unequipping and deterioration of the item's imbue time
Quiver checking for ammunition level (@andersonfaaria, https://github.com/opentibiabr/canary/commit/f50096b) Description Added check for minReqLevel of ammunitions in quiver both for total count of arrow as well as to select which ammunition to use Actual behaviour Quiver ignore level requirement as stated in https://github.com/opentibiabr/canary/issues/77 Expected behaviour Quiver actually doesn't throw ammunitions which has higher level requirement than player level
Fixed on death events for monsters that don't have corpses (@dudantas, https://github.com/opentibiabr/canary/commit/6db7c30) onDeath events not working for corpseless monsters Added a sanity check to ensure the corpse is not used by monsters that don't have a corpse
Fix green skull from party (653c65a) Fix missing green skull on current character
Fix crash of invalid discord url and wrong player death event name typo (@beats-dh, https://github.com/opentibiabr/canary/commit/5714e14) Fixed player death event name typo (from "Player Death" to "PlayerDeath"), on login.lua is: player:registerEvent("PlayerDeath") Fixed a bug that we have in the discord webhook in the project, and the bug happens when the server can't access the discord because of an invalid url or a lack of connection from the discord itself Behaviour actual: Server crash "closes unexpectedly" if invalid url is set in "config.lua" or "discord_webhook.lua" Expected: The server has to work normally regardless of whether the url is correct or not and whether discord receives it or not
Remove increment rune name to item name (@dudantas, https://github.com/opentibiabr/canary/commit/08087b0) Item name was being replaced by rune name in "register" function Added the condition to only replace if the item name is empty, so that some system that checks the name of the pre-established item cannot be bugged
Fixed bug where quickloot would only looting the first corpses (@dudantas, https://github.com/opentibiabr/canary/commit/0e75d7b)
Convert destroy field rune ids to client id and remove unused corpses table (@gpedro, https://github.com/opentibiabr/canary/commit/93d9d98)
Fix exercise training and somes nil scripts (@dudantas, https://github.com/opentibiabr/canary/commit/1f81077)
Conversion of server id to client id on gamestore.lua and init.lua and indent file gamestore.lua (@dudantas, https://github.com/opentibiabr/canary/commit/f81f904)
Add 'non-aggresive' tag on healing 'doTargetCombatHealth' (@marcosv132, https://github.com/opentibiabr/canary/commit/6f42a91) Missing check to make the combat 'non-aggresive' when healing a player's mana, by potion or any script that uses doTargetCombatHealth(...)
Remove unsafe addEvent from gamestore (@andersonfaaria, https://github.com/opentibiabr/canary/commit/1330cef)
Fix crash related to reload scripts and fix reload npcs not working correctly and others fixes (see description) (@dudantas, https://github.com/opentibiabr/canary/commit/5141874) This is intended to: Resolve critical issues. See all description on the commit.
Fixed rune that was only used in the tile and added to set for no-moveable item for action by position (@dudantas, https://github.com/opentibiabr/canary/commit/1da1ac1) Moved the check inside the iterator, making the rune no longer access the tile check and can be used inside the backpack Modified so if the item set to be crafted is a moveable item, then the script will set the unmovable flag to prevent any player from moving the item.
Add missing function and fix nil values scripts (@dudantas, https://github.com/opentibiabr/canary/commit/fa74d67) Added function for summon familiar and fixed somes wrong functions
Fixed halved healing spells, changed overtime healing color from blue to red (@soderlight, https://github.com/opentibiabr/canary/commit/d58c242)
Fix typo on config tags from "togle" to "toggle" and somes others fixes (@dudantas, https://github.com/opentibiabr/canary/commit/c921c87) Added the "global" in the tags of the global save server, and some synchronizations with the global repository: https://github.com/opentibiabr/otservbr-global
Fix drowning logic (@lucasgrizante, https://github.com/opentibiabr/canary/commit/5c42078
Fix rune "id" method incrementing item id in the items.xml (@dudantas, https://github.com/opentibiabr/canary/commit/0ea8dd6) Method "spell:id()" is of use only of spell instant, to set the cooldown sprite
Fix convert daily reward ids to client id (@lucasgrizante, https://github.com/opentibiabr/canary/commit/1ca7847)

GitHub

Set workflows branch from "master" to "main" (@dudantas, https://github.com/opentibiabr/canary/commit/46cf35b)
Update GitHub actions (@costallat, https://github.com/opentibiabr/canary/commit/a9cd5c7) Update and improve Github Actions Add new forms Update bug form Fix labels
Add issue auto label (@costallat, https://github.com/opentibiabr/canary/commit/76fd4f6)
Set windows default build as release (@costallat, https://github.com/opentibiabr/canary/commit/657db93) Refactor cmake presets to keep windows release as the default preset to help newcomers
Fix build docker, missing include header (@dudantas, https://github.com/opentibiabr/canary/commit/c02a492) Added the proper checks in the addImbuement function The setImbuement Function has been set to private, to prevent someone from using it and making the bug again Added clearImbuement function to clear imbuement
[Remove] Removed benchmark from storage duplication (@andersonfaaria, https://github.com/opentibiabr/canary/commit/0b218582) This was something I have added back then to show the function wasn't heavy and it's already something proven. In one of the commits someone put the processed message inside the condition which removed its purpose and would spam server console with a line that is not relevant as the goal was to show total process time and not individual time for each duplicate found.

Closed issues:

OTServBR-Global Modifications

Enhancements/Features

Add 12.72 monsters (@guispiller, bbb4cba3)
(Canary Compatibility) fix life and mana leech amount/chance attribute @guispiller, 37caf0d2) Source code: https://github.com/opentibiabr/canary/commit/56ddcf2f8ea5915691c10ab94fc856a40f0060d5
(Chore) use const variable instead of hardcored id in "hireling lamp" script (@gpedro, c1c43dfc)
(Canary Compatibility) Canary pull requests (@omeranha, 1e6150d0) https://github.com/opentibiabr/canary/pull/147 https://github.com/opentibiabr/canary/pull/169 https://github.com/opentibiabr/canary/pull/184 https://github.com/opentibiabr/canary/pull/221
(Canary Compatibility) - Move npcs from "npclua" to "npc" folder (@dudantas, b2d8aaa9)
(Canary Compatiblity) syncronization with canary after release 1.2 (@beats-dh, ec9b652f) This modification need of the canary commit: https://github.com/opentibiabr/canary/commit/c921c8733b26e6e3a314f0514b9eba374b9edc2b
(Canary Compatibility) Rework on items to extinquish OTB file and use client 12 protobuf instead (@marcosvf132, https://github.com/opentibiabr/canary/commit/2d59b5e9) Caution: It is extremely important that the canary source be used from this commit: https://github.com/opentibiabr/canary/commit/68d0475cf2bd9ee6295f00ef644a9b7bd4d67e6f
Additional files to work with new map updates and fix Sinister Hermit monster (@guispiller, a680a2d7) This pr need of the protobuf from canary: https://github.com/opentibiabr/canary/commit/68d0475cf2bd9ee6295f00ef644a9b7bd4d67e6f And protobuf from this repository: https://github.com/opentibiabr/otservbr-global/commit/2d59b5e9a4643e14d6d81c6f62fadeef88bb0526

Fixed problems (Global):

Convert ids from dawnport quest to client id and register items for knight (@painer15999, bf89f028)
Fix npc puffels npcHandler variable (@soderlight, 1a7518e4)
Fix script decay.lua for work only for players (@dudantas, b0104452)
Fix script potions.lua effect and create flask inside container (@omeranha, e26f8642)
Fix wrong heavy package ID (rashid quest) (@soderlight, a503d78e)
Fix npcs shop and reward chest attribute (@dudantas, 3c3b9c71)
Fix items ids and attributes (@majestyotbr, 30469967)
Remove benchmark details (@andersonfaaria, de39c8f6)
Added missing royal spear config to npcs: Brengus, Cedrik, Robert and Willard (@kasiula03, e56efe8b)
Fix NPCs Captain Max (Calassa), Grizzly Adams and Melfar (@soderlight, 3395293f)
Added corpseType to some corpses (@rechdan, 4104b3f1)
(Canary Compatibility) Fix item tier (@marcosvf132, d2b5d5db) To syncronize Canary and OTServBR-Global changes. https://github.com/opentibiabr/canary/commit/4c7a35a382f15de5c5bb07df9c6bacb094e4e4f4
Convert map 'nightmare isle/darashia-west' from serverID to clientID (@marcosvf132, f344d0b1)
Modifications on Player:onLook, fix quests.lua order, remove duplicate ids and fix suggestions from lua extension (@beats-dh, dd353ff6)
Many item.xml fixes + login.lua indentation (@guispiller, c095b328) This changes are to fix some missing otbr/canary converting ids, there were some decays, rotates and wraps with the wrong IDs QoL on channels login.lua
Few hireling issues (@marcosvf132, 279bf759) Fix hireling outfit change client crash. Fix hireling server crash when saying 'hi - lamp - yes'.
Fix familiar not entering pz zone and improvement to familiar spells (@dudantas, 4416bdfb)
Fix minotaur cult monsters (@dybik08, 3f46da44) This contains fixes for minotaur cult monsters.
Fix "Wound" bestiary charm register (@marcosvf132, 9a9c34ce) Wound bestiary charm was not showing on the cyclopedia charm store due to one miss config on the Lua file.
Fix talkDelay from npcs (@dudantas, 712b9841) Resolves #486 Added delay to the function "NpcHandler:setMessage" and fixed talkDelay from the others functions. The modifications only apply to speeches that contain more than one message.
Fix nil errors on somes scripts (@dudantas, 723d6970)
Register missing enchanted werewolf amulet (@dudantas, 8bbe05dc)
Somes npcs fixes (wrong functions and missing variables) (@dudantas, c538fcff) Set from delayedSay and selfSay to npcHandler:say and fixed somes missing/wrong variables Fixed hireling crash (bad handle on SayEvent function)
Fix allowMovement storage typo (@gpedro, 174f4d1d) Fixed typo from STORAGE to Storage in "allowMovement" and "hasAllowMovement" functions
Fix party skills (@kasiula03, e85fcac3) Fix naming for variable parameter in onCastSpell for train_party, heal_party and protect_party scripts. Additionally, shielding buff has been changed from 2 to 3 to match real tibia skill.
Fix key doors (not registered key 2969), dawnport quest and thieves guild quest (@dudantas, 354b7221)
Fix bug in enchanted werewolf and enchanted theurgic amulets and registed cobra crossbow attributes (@painer15999, 3fb9cf0)
Fix message type of locked door from event advance to info descr (@travisani, 099f34fa)
Remove unsafe use of AddEvent in Oberon (@gpedro, @gesior, ebe238e4) Resolves #476
Fix revision on monster flags and elemental damages (@guispiller, ad635b6a)
Fix healing source on 'mass healing' and potions (@marcosvf132, 1c70b1a3) Using the spell 'exura gran mas res' or using a health potion on another player is not registering the source of the action. This PR add it so the server, the client and other systems can track the action how it should be.
Fix Client IDs on NPCs and quest_system2 (@guispiller, 65aa5f1)
Convert ids to client id, storages fixes and quests fixes (@soderlight, 70bd1816)
Fixing wrong aid and uid conversions (@guispiller, a8206487)
Remove unsafe addEvent from gamestore (@andersonfaaria, 83754e7b)
Fix Destroy Rune field list (@andersonfaaria, fb285f40) Moved lib table to script rune Converted server ids to client id
Fix NPCs not working due to wrong parameters (@guispiller, d02d8473)
Fix nil storages from ferumbras ascendant quest (@dudantas, d388b133)
Fix keys would be given without proper key actions (@lucascebertin, ee549854) Fix issue #528 where some keys are given without proper key actions.
Fix weapons shoot effects and eldritch wands/rods not attacking (@guispiller, 8e1eb612)
Add missing outfits and mounts to talkactions (@daanyx, 75ea3ec6)
(Npc) Convert shop from Gnomally to client id (@gpedro, 556a5dab)
(Npc) Update items from Willard shop sell (@sircurse, 1212d2eb)
(Npc) fix Eruaran addons (@gpedro, bb926cbd)
(Canary Compatibility) - Prey system rework (CPP) and Hunting Task system (@marcosvf132, db97c32a) This PR is a complementation of this Canary commit: https://github.com/opentibiabr/canary/commit/42af88d201cd3d4afed91445b1ac13ebabf76986 Complete rewrite of old prey system from LUA to CPP and implementation of Hunting tasks system.
Fix mana potion not healing mana (@dudantas, e101237c)
(Npc) changed prices in NPC Imbuement to avoid illicit enrichment (@sircurse, 941aa233) This NPC was selling imbuements items at a very low price, for instance, you could buy "Some Grimeleech Wings" at 100gps and sell this same item to Yasir by 1200gps
Rework and fix on kegs and casks scripts (@dudantas, 9d9a2e81) Script logic reworked, fixed some bugs and removed unnecessary checks
Fix offline training bed (bed graphics was not updating when player went to sleep) (@sircurse, 2a3bfdde) Fix to issue #526
Fix rune "id" method incrementing item id in the items.xml (@dudantas, bdc756af) Canary commit (optional): https://github.com/opentibiabr/canary/commit/0ea8dd6d7acc15c9213d760a709ec1a6478d478b
Fix npcs name on script "npcs by time" and fix on startup spawn npcs by night/day (@dudantas, 6eeedef0) Added the monsters in npcs.xml, attached the NPCS name in the Global Event script and added the Respawntype tags for whether each NPC must be created (when opening the server) during the day or night
(Canary Compatibility) Rework on fluids colors and new monster race type (INK) (@marcosvf132, 87e53b93)
Fix for cask to be used in house only and removing wrong charges and empty potion flasks (@dudantas, ecbfdcbe)

Closed issues:

#279, #281, #282, #286, #292, #299, #313, #319, #336, #357, #358, #376, #385, #386, #406, #409, #424, #429, #432, #433, #438, #439, #441, #447, #449, #450, #451, #452, #453, #456, #459, #460, #462, #468, #474, #476, #478, #481, #484, #486, #494, #495, #497, #500, #502, #506, #509, #510, #520, #522, #526, #527, #528, #530, #534, #552, #563

Global map new areas and fixes (Credits to @majestyotbr, @JohneVictor, @guispiller):

Complete modifications in the commit: https://github.com/opentibiabr/otservbr-global/commit/2d59b5e9a4643e14d6d81c6f62fadeef88bb0526

Antrum of the Fallen - pos 32603, 31844, 10; Bounacean Lion - pos 32470, 32492, 8; Boss Room Neferi The Spy - 33886, 31477, 6, ; Boss Room Sister Hetai - 33883, 31467, 9,; Cursed Crypt - pos 32601, 31861, 9; Deathling Menace - pos 32366, 32543, 8; Dwelling of the Forgotten - pos 32062, 31461, 11; Forest of Life - pos 32399, 32496, 11; Forge (Thanks for Stewart) - pos 32208, 32281, 7; Gaffir Secret Room - 33302, 31196, 9; Grotto of the Lost - pos 32123, 31442, 14; Ruins of Nuur - pos 33806, 31692, 8; Salt Caves - pos 33970, 31652, 7; Too Hot To Handle - pos 32603, 31844, 10; Task: Lava Fishing - pos 32532, 31086, 15; Task: The Mega Magmaoid - pos 32529, 31154, 15; Room Lesh The Seer - pos 32406, 32470, 6; Stealth Mission - pos 33894, 31311, 15; Supply Mission - pos 33964, 31307, 15; 1st Mate Ratticus - pos 33897, 31391, 15; The Trekkie's Journey - pos 33960, 31375, 15; Haunted House - pos 32690, 32241, 6; Tomb of Scarlet - pos 33101, 32630, 8; Tibia Cults - pos 33039, 31911, 14; Hunt Feaster of Soul - pos 31912, 32355, 8; Boss Room The Brainstealer - pos 32539, 31122, 15; Rascacoon Kraken Boss - pos 33803, 31390, 7, / 33733, 31187, 7; A Pirates Tail - pos 33927, 31364, 7;

stable-v1.3.0

2 years ago

Tibia Client 12.86.11871

OTClient 1.0

Canary:

Features/Enhancements

Complete rework on npcs shop add item functions (@dudantas, https://github.com/opentibiabr/canary/commit/caf0a970)
Experience tracker (@marcosvf132, https://github.com/opentibiabr/canary/commit/990da240) On the oldest protocols, the client was handling the experience changes by it's own, now on the new protorocol (12.72+), we need to send to the client the right amount of experience that the player has gainned so it can update it's tracker
Auto Loot, Quick Looting in stack and Auto Bank function (@omeranha, https://github.com/opentibiabr/canary/commit/5cb9ff7b) Auto loot using your manage loot containers quick loot categories and items filter, can be enabled in config.lua! Quick loot in stack, up to 30 corpses, enabled using client option. Auto Bank function, the dropped coins from monsters will be automatically deposited to your bank account, can be enabled in config.lua.
No disconnect on death (@omeranha, https://github.com/opentibiabr/canary/commit/4f8667a6) no more disconnection when player dies
Solved incompatibility problem with otclient redemption (@marcosvf132, https://github.com/opentibiabr/canary/commit/c46f64d2) Readjust protocolgame to follow the right pattern. Changing hardcoded expected bytes on OnRecvFirstMessage to follow the cip client and fix incompatible with otclient protocolgamesend.
Decouple g_game in true singleton (@dudantas, @lgrossi, https://github.com/opentibiabr/canary/commit/126e7df) Game class decoupled in a true singleton, thus allowing direct calls without needing to instantiate in each file. Credits to @lgrossi for made the decouple logic.
Fix build to not use asan on relase mode (@costallat, https://github.com/opentibiabr/canary/commit/87edf62) Not use ASAN for release build Remove cmake settings(replaced with presets) Adjust GitHub Actions triggers
Cmake features and update workflows to use gcc 11 (@dudantas, https://github.com/opentibiabr/canary/commit/905f774) Update sonarcloud version and sonar/codeql/ubuntu build to use gcc 11 Added gcc minimum version 8 in cmakelists.txt Reorganized find_packages Fix possible bug in the spdlog link library
Add tag serverSaveTime on config.lua (@beats-dh, https://github.com/opentibiabr/canary/commit/e848604) With this modification, the configuration of the global server save can be done directly in config.lua, thus centralizing configurable things in a single place
Add missing librarys; daily reward, modal windows and reward boss (@dudantas, https://github.com/opentibiabr/canary/commit/c45f1d2) Added somes missing librarys: daily reward, modal window, reward boss Added new scripts for: monsters and spells
Party hunt analyzer. (@marcosvf132, https://github.com/opentibiabr/canary/commit/c17279a) Adding the "new" feature Party Hunt Analyzer. There is one thing that you must know before you start testing it, so please read the entire PR commentary.
Added not moveable action function (@dudantas, https://github.com/opentibiabr/canary/commit/9c49c95) Not moveable action id = 100 So that the item cannot be moved, just put this action id in the item
Add windows relelease build with address sanitizer (@costallat, https://github.com/opentibiabr/canary/commit/8552c10) Adds new release build with asan enabled to help tracking problems
Added missing effects from version 12: soulwar/tentugly/supreme cube (@aerwix, https://github.com/opentibiabr/canary/commit/371f116)
Added a new method to register scripts by the map position and rework on "registerLuaEvent" function (@dudantas, https://github.com/opentibiabr/canary/commit/a7e6426) See all description on the commit With this modification, we can register action scripts without needing the action id/unique id or the item being on the map, as there is also a second parameter that creates the item (if it doesn't exist).
Decouple all global variables from extern in true singleton (@beats-dh, @lgrossi, https://github.com/opentibiabr/canary/commit/b87372f) All the global variables * g_* were decoupled to true singletons, reducing the dependencies between the objects and simplifying the amount of calls and instances. They used to be partial singletons mixed with global variables, that way we have one, and only one instance that is accessed via the getInstance methods, that are now the * g_* functions.
Prey system rework (CPP) + Hunting task system (@marcosvf132, https://github.com/opentibiabr/canary/commit/42af88d) Complete rewrite of old prey system from LUA to CPP and implementation of Hunting Tasks system; Do not test with GOD char or with low amount of creatures registered on bestiary. The PR already include the necessary amount of then; Addition of hunting task system and entire rework of prey system. All working on CPP with few LUA integration.
Check for message type parameter wrong (@dudantas, https://github.com/opentibiabr/canary/commit/ea7fbce) How to test: Add a message with a wrong or none parameter, such as: player:sendTextMessage(MESSAGE_WRONG, "Message")
Rework on fluids colors and new monster race type (INK) (@marcosvf132, https://github.com/opentibiabr/canary/commit/ce36520) Description Full rework on the way that the server handles the fluids, to use one single ENUM and remove all the garbage functions and maps that used to store the same values for fluids over and over again. Add new creature race type named INK. This new race type is used mostly on creatures on the tibia "The Secret Library". Attacking those creatures or slain then will now create the proper type of blood pool/splash. Resolves https://github.com/opentibiabr/canary/issues/123 OTServerBr-Global PR: https://github.com/opentibiabr/otservbr-global/pull/544
Add script casks and kegs (store item for refill potions) (@lucasgrizante, https://github.com/opentibiabr/canary/commit/256a6ee)
Move client version from config.lua to definitions.h (@dudantas, https://github.com/opentibiabr/canary/commit/4580324c) It's a tag that works at the compilation level and shouldn't be in config.lua, because the version is always just one and cannot be modified at the configuration level.
Rework on items to extinquish OTB file and use client 12 protobuf instead (@marcosvf132, https://github.com/opentibiabr/canary/commit/68d0475c) See the commit description for more information

New Lua functions

Added container:getItems() function and option stash moving items to supply stash and depot (@omeranha, https://github.com/opentibiabr/canary/commit/844530b7)

Fix

Register Npc Type - add missing currency method for npcs revscriptsys (@aerwix, https://github.com/opentibiabr/canary/commit/9f37c02a)
Bestiary tracker list loader (@marcosvf132, https://github.com/opentibiabr/canary/commit/9a02596f)
Reverting item tier to 0 + Market/Cyclopedia item tier (@marcosvf132, https://github.com/opentibiabr/canary/commit/4c7a35a3)
Life and mana leech amount/chance attribute (@guispiller, https://github.com/opentibiabr/canary/commit/56ddcf2f) Fix to correct the item tags of mana leech and life leech items attributes. Extra: added attributes missing on some soulwar weapons.
"allowpickupable" tag on items.xml, resolves trashholder items (@dudantas, https://github.com/opentibiabr/canary/commit/e3df5835)
Ring transformation on creation (@marcosvf132, https://github.com/opentibiabr/canary/commit/0eacb35b) Rings was transforming into wrong itemIDs on creation.
Add missing duration timestamp attribute for decay system (@beats-dh, https://github.com/opentibiabr/canary/commit/15275499)
logout message connection lost on bed and offline training and remove unused tag on druid familiar (@omeranha, https://github.com/opentibiabr/canary/commit/e6abcc8f) Fixes connection lost message when using an bed or offline training statues, added a check to identify when a player was "forced" removed
Auto Bank not removing coins from monster corpse (@omeranha, https://github.com/opentibiabr/canary/commit/0059314e)
docker-compose: add env to correct mysql host (@bruno-costa, https://github.com/opentibiabr/canary/commit/611a44ef)
Few hireling issues (@marcosvf132, https://github.com/opentibiabr/canary/commit/3808591d) Fix hireling outfit change client crash. Fix hireling server crash when saying 'hi - lamp - yes'. Convert hireling itemids from serverID to clientID.
'wound' bestiary charm register (@marcosvf132, https://github.com/opentibiabr/canary/commit/deeb21ff) Wound bestiary charm was not showing on the cyclopedia charm store due to one miss config on the Lua file.
Multiple purchase of the same mount from store. (@corlyone, https://github.com/opentibiabr/canary/commit/3e94dc2b) When buying a mount, it was possible to buy it indefinitely, causing the player to lose coins.
Not be able to accept offer if you are a character on the same account (@dudantas, https://github.com/opentibiabr/canary/commit/65b53485) Fix for player selling offer not receiving money if offline (thanks and credits for @gccris) Added verification to prevent transactions with characters of the same account
[Fx] Rework of checkCreatureAsKnown and fix of client debug (@beats-dh, @lgrossi, https://github.com/opentibiabr/canary/commit/77f152e3) Before, if you moved with the char diagonally for a while or even normally at a certain time, the debug client "closes unexpectedly" with this fix it doesn't happen anymore. Note: walking diagonally forces the client to debug faster. Credits fix code: @mrianura
crash on buy own offer in market (@dudantas, https://github.com/opentibiabr/canary/commit/d488fae) Removed some unnecessary delete pointers
Added check to ensure the item is not imbued twice with the same imbuement (@dudantas, https://github.com/opentibiabr/canary/commit/dd03479)
Add decayImbuementTime function for use of updateInventoryImbuement (@dudantas, https://github.com/opentibiabr/canary/commit/8559f3c) Function to avoid sending the message "imbuement already exists" when equipping/unequipping and deterioration of the item's imbue time
Quiver checking for ammunition level (@andersonfaaria, https://github.com/opentibiabr/canary/commit/f50096b) Description Added check for minReqLevel of ammunitions in quiver both for total count of arrow as well as to select which ammunition to use Actual behaviour Quiver ignore level requirement as stated in https://github.com/opentibiabr/canary/issues/77 Expected behaviour Quiver actually doesn't throw ammunitions which has higher level requirement than player level
Fixed on death events for monsters that don't have corpses (@dudantas, https://github.com/opentibiabr/canary/commit/6db7c30) onDeath events not working for corpseless monsters Added a sanity check to ensure the corpse is not used by monsters that don't have a corpse
Fix green skull from party (653c65a) Fix missing green skull on current character
Fix crash of invalid discord url and wrong player death event name typo (@beats-dh, https://github.com/opentibiabr/canary/commit/5714e14) Fixed player death event name typo (from "Player Death" to "PlayerDeath"), on login.lua is: player:registerEvent("PlayerDeath") Fixed a bug that we have in the discord webhook in the project, and the bug happens when the server can't access the discord because of an invalid url or a lack of connection from the discord itself Behaviour actual: Server crash "closes unexpectedly" if invalid url is set in "config.lua" or "discord_webhook.lua" Expected: The server has to work normally regardless of whether the url is correct or not and whether discord receives it or not
Remove increment rune name to item name (@dudantas, https://github.com/opentibiabr/canary/commit/08087b0) Item name was being replaced by rune name in "register" function Added the condition to only replace if the item name is empty, so that some system that checks the name of the pre-established item cannot be bugged
Fixed bug where quickloot would only looting the first corpses (@dudantas, https://github.com/opentibiabr/canary/commit/0e75d7b)
Convert destroy field rune ids to client id and remove unused corpses table (@gpedro, https://github.com/opentibiabr/canary/commit/93d9d98)
Fix exercise training and somes nil scripts (@dudantas, https://github.com/opentibiabr/canary/commit/1f81077)
Conversion of server id to client id on gamestore.lua and init.lua and indent file gamestore.lua (@dudantas, https://github.com/opentibiabr/canary/commit/f81f904)
Add 'non-aggresive' tag on healing 'doTargetCombatHealth' (@marcosv132, https://github.com/opentibiabr/canary/commit/6f42a91) Missing check to make the combat 'non-aggresive' when healing a player's mana, by potion or any script that uses doTargetCombatHealth(...)
Remove unsafe addEvent from gamestore (@andersonfaaria, https://github.com/opentibiabr/canary/commit/1330cef)
Fix crash related to reload scripts and fix reload npcs not working correctly and others fixes (see description) (@dudantas, https://github.com/opentibiabr/canary/commit/5141874) This is intended to: Resolve critical issues. See all description on the commit.
Fixed rune that was only used in the tile and added to set for no-moveable item for action by position (@dudantas, https://github.com/opentibiabr/canary/commit/1da1ac1) Moved the check inside the iterator, making the rune no longer access the tile check and can be used inside the backpack Modified so if the item set to be crafted is a moveable item, then the script will set the unmovable flag to prevent any player from moving the item.
Add missing function and fix nil values scripts (@dudantas, https://github.com/opentibiabr/canary/commit/fa74d67) Added function for summon familiar and fixed somes wrong functions
Fixed halved healing spells, changed overtime healing color from blue to red (@soderlight, https://github.com/opentibiabr/canary/commit/d58c242)
Fix typo on config tags from "togle" to "toggle" and somes others fixes (@dudantas, https://github.com/opentibiabr/canary/commit/c921c87) Added the "global" in the tags of the global save server, and some synchronizations with the global repository: https://github.com/opentibiabr/otservbr-global
Fix drowning logic (@lucasgrizante, https://github.com/opentibiabr/canary/commit/5c42078
Fix rune "id" method incrementing item id in the items.xml (@dudantas, https://github.com/opentibiabr/canary/commit/0ea8dd6) Method "spell:id()" is of use only of spell instant, to set the cooldown sprite
Fix convert daily reward ids to client id (@lucasgrizante, https://github.com/opentibiabr/canary/commit/1ca7847)

GitHub

Set workflows branch from "master" to "main" (@dudantas, https://github.com/opentibiabr/canary/commit/46cf35b)
Update GitHub actions (@costallat, https://github.com/opentibiabr/canary/commit/a9cd5c7) Update and improve Github Actions Add new forms Update bug form Fix labels
Add issue auto label (@costallat, https://github.com/opentibiabr/canary/commit/76fd4f6)
Set windows default build as release (@costallat, https://github.com/opentibiabr/canary/commit/657db93) Refactor cmake presets to keep windows release as the default preset to help newcomers
Fix build docker, missing include header (@dudantas, https://github.com/opentibiabr/canary/commit/c02a492) Added the proper checks in the addImbuement function The setImbuement Function has been set to private, to prevent someone from using it and making the bug again Added clearImbuement function to clear imbuement
[Remove] Removed benchmark from storage duplication (@andersonfaaria, https://github.com/opentibiabr/canary/commit/0b218582) This was something I have added back then to show the function wasn't heavy and it's already something proven. In one of the commits someone put the processed message inside the condition which removed its purpose and would spam server console with a line that is not relevant as the goal was to show total process time and not individual time for each duplicate found.

Closed issues:

OTServBR-Global Modifications

Enhancements/Features

Add 12.72 monsters (@guispiller, bbb4cba3)
(Canary Compatibility) fix life and mana leech amount/chance attribute @guispiller, 37caf0d2) Source code: https://github.com/opentibiabr/canary/commit/56ddcf2f8ea5915691c10ab94fc856a40f0060d5
(Chore) use const variable instead of hardcored id in "hireling lamp" script (@gpedro, c1c43dfc)
(Canary Compatibility) Canary pull requests (@omeranha, 1e6150d0) https://github.com/opentibiabr/canary/pull/147 https://github.com/opentibiabr/canary/pull/169 https://github.com/opentibiabr/canary/pull/184 https://github.com/opentibiabr/canary/pull/221
(Canary Compatibility) - Move npcs from "npclua" to "npc" folder (@dudantas, b2d8aaa9)
(Canary Compatiblity) syncronization with canary after release 1.2 (@beats-dh, ec9b652f) This modification need of the canary commit: https://github.com/opentibiabr/canary/commit/c921c8733b26e6e3a314f0514b9eba374b9edc2b
(Canary Compatibility) Rework on items to extinquish OTB file and use client 12 protobuf instead (@marcosvf132, https://github.com/opentibiabr/canary/commit/2d59b5e9) Caution: It is extremely important that the canary source be used from this commit: https://github.com/opentibiabr/canary/commit/68d0475cf2bd9ee6295f00ef644a9b7bd4d67e6f
Additional files to work with new map updates and fix Sinister Hermit monster (@guispiller, a680a2d7) This pr need of the protobuf from canary: https://github.com/opentibiabr/canary/commit/68d0475cf2bd9ee6295f00ef644a9b7bd4d67e6f And protobuf from this repository: https://github.com/opentibiabr/otservbr-global/commit/2d59b5e9a4643e14d6d81c6f62fadeef88bb0526

Fixed problems (Global):

Convert ids from dawnport quest to client id and register items for knight (@painer15999, bf89f028)
Fix npc puffels npcHandler variable (@soderlight, 1a7518e4)
Fix script decay.lua for work only for players (@dudantas, b0104452)
Fix script potions.lua effect and create flask inside container (@omeranha, e26f8642)
Fix wrong heavy package ID (rashid quest) (@soderlight, a503d78e)
Fix npcs shop and reward chest attribute (@dudantas, 3c3b9c71)
Fix items ids and attributes (@majestyotbr, 30469967)
Remove benchmark details (@andersonfaaria, de39c8f6)
Added missing royal spear config to npcs: Brengus, Cedrik, Robert and Willard (@kasiula03, e56efe8b)
Fix NPCs Captain Max (Calassa), Grizzly Adams and Melfar (@soderlight, 3395293f)
Added corpseType to some corpses (@rechdan, 4104b3f1)
(Canary Compatibility) Fix item tier (@marcosvf132, d2b5d5db) To syncronize Canary and OTServBR-Global changes. https://github.com/opentibiabr/canary/commit/4c7a35a382f15de5c5bb07df9c6bacb094e4e4f4
Convert map 'nightmare isle/darashia-west' from serverID to clientID (@marcosvf132, f344d0b1)
Modifications on Player:onLook, fix quests.lua order, remove duplicate ids and fix suggestions from lua extension (@beats-dh, dd353ff6)
Many item.xml fixes + login.lua indentation (@guispiller, c095b328) This changes are to fix some missing otbr/canary converting ids, there were some decays, rotates and wraps with the wrong IDs QoL on channels login.lua
Few hireling issues (@marcosvf132, 279bf759) Fix hireling outfit change client crash. Fix hireling server crash when saying 'hi - lamp - yes'.
Fix familiar not entering pz zone and improvement to familiar spells (@dudantas, 4416bdfb)
Fix minotaur cult monsters (@dybik08, 3f46da44) This contains fixes for minotaur cult monsters.
Fix "Wound" bestiary charm register (@marcosvf132, 9a9c34ce) Wound bestiary charm was not showing on the cyclopedia charm store due to one miss config on the Lua file.
Fix talkDelay from npcs (@dudantas, 712b9841) Resolves #486 Added delay to the function "NpcHandler:setMessage" and fixed talkDelay from the others functions. The modifications only apply to speeches that contain more than one message.
Fix nil errors on somes scripts (@dudantas, 723d6970)
Register missing enchanted werewolf amulet (@dudantas, 8bbe05dc)
Somes npcs fixes (wrong functions and missing variables) (@dudantas, c538fcff) Set from delayedSay and selfSay to npcHandler:say and fixed somes missing/wrong variables Fixed hireling crash (bad handle on SayEvent function)
Fix allowMovement storage typo (@gpedro, 174f4d1d) Fixed typo from STORAGE to Storage in "allowMovement" and "hasAllowMovement" functions
Fix party skills (@kasiula03, e85fcac3) Fix naming for variable parameter in onCastSpell for train_party, heal_party and protect_party scripts. Additionally, shielding buff has been changed from 2 to 3 to match real tibia skill.
Fix key doors (not registered key 2969), dawnport quest and thieves guild quest (@dudantas, 354b7221)
Fix bug in enchanted werewolf and enchanted theurgic amulets and registed cobra crossbow attributes (@painer15999, 3fb9cf0)
Fix message type of locked door from event advance to info descr (@travisani, 099f34fa)
Remove unsafe use of AddEvent in Oberon (@gpedro, @gesior, ebe238e4) Resolves #476
Fix revision on monster flags and elemental damages (@guispiller, ad635b6a)
Fix healing source on 'mass healing' and potions (@marcosvf132, 1c70b1a3) Using the spell 'exura gran mas res' or using a health potion on another player is not registering the source of the action. This PR add it so the server, the client and other systems can track the action how it should be.
Fix Client IDs on NPCs and quest_system2 (@guispiller, 65aa5f1)
Convert ids to client id, storages fixes and quests fixes (@soderlight, 70bd1816)
Fixing wrong aid and uid conversions (@guispiller, a8206487)
Remove unsafe addEvent from gamestore (@andersonfaaria, 83754e7b)
Fix Destroy Rune field list (@andersonfaaria, fb285f40) Moved lib table to script rune Converted server ids to client id
Fix NPCs not working due to wrong parameters (@guispiller, d02d8473)
Fix nil storages from ferumbras ascendant quest (@dudantas, d388b133)
Fix keys would be given without proper key actions (@lucascebertin, ee549854) Fix issue #528 where some keys are given without proper key actions.
Fix weapons shoot effects and eldritch wands/rods not attacking (@guispiller, 8e1eb612)
Add missing outfits and mounts to talkactions (@daanyx, 75ea3ec6)
(Npc) Convert shop from Gnomally to client id (@gpedro, 556a5dab)
(Npc) Update items from Willard shop sell (@sircurse, 1212d2eb)
(Npc) fix Eruaran addons (@gpedro, bb926cbd)
(Canary Compatibility) - Prey system rework (CPP) and Hunting Task system (@marcosvf132, db97c32a) This PR is a complementation of this Canary commit: https://github.com/opentibiabr/canary/commit/42af88d201cd3d4afed91445b1ac13ebabf76986 Complete rewrite of old prey system from LUA to CPP and implementation of Hunting tasks system.
Fix mana potion not healing mana (@dudantas, e101237c)
(Npc) changed prices in NPC Imbuement to avoid illicit enrichment (@sircurse, 941aa233) This NPC was selling imbuements items at a very low price, for instance, you could buy "Some Grimeleech Wings" at 100gps and sell this same item to Yasir by 1200gps
Rework and fix on kegs and casks scripts (@dudantas, 9d9a2e81) Script logic reworked, fixed some bugs and removed unnecessary checks
Fix offline training bed (bed graphics was not updating when player went to sleep) (@sircurse, 2a3bfdde) Fix to issue #526
Fix rune "id" method incrementing item id in the items.xml (@dudantas, bdc756af) Canary commit (optional): https://github.com/opentibiabr/canary/commit/0ea8dd6d7acc15c9213d760a709ec1a6478d478b
Fix npcs name on script "npcs by time" and fix on startup spawn npcs by night/day (@dudantas, 6eeedef0) Added the monsters in npcs.xml, attached the NPCS name in the Global Event script and added the Respawntype tags for whether each NPC must be created (when opening the server) during the day or night
(Canary Compatibility) Rework on fluids colors and new monster race type (INK) (@marcosvf132, 87e53b93)
Fix for cask to be used in house only and removing wrong charges and empty potion flasks (@dudantas, ecbfdcbe)

Closed issues:

Global map new areas and fixes (Credits to @majestyotbr, @JohneVictor, @guispiller):

Complete modifications in the commit: https://github.com/opentibiabr/otservbr-global/commit/2d59b5e9a4643e14d6d81c6f62fadeef88bb0526

stable-v1.2.0

2 years ago

Canary Modifications

Support client 12.85.11525 (author: @marcosvf132, commits: (https://github.com/opentibiabr/canary/commit/e9c85a5, https://github.com/opentibiabr/canary/commit/3144b16, https://github.com/opentibiabr/canary/commit/cc98f40)

Modified (Canary):

[Lua/Pack]: Remove lua tests, the files no longer exist (author: @omeranha, commit: (https://github.com/opentibiabr/canary/commit/9a21ad4)
[Source]: Enhancement - Automatically unzip world.zip in world folder if otbm file doesn't exist on server start (author: @omeranha, commit: (https://github.com/opentibiabr/canary/commit/6b23e6f) This change will allow the server to automatically extract the map from the zip (to the global server) in case the .otbm file is not found. In this commit is need new lib libzippp, uses ./vcpkg install libzippp

Fixed problems (Canary):

[Source]: Npc Shop Enhancement - Allow an item of the same id to be added multiple times for the same npc (author: @dudantas, commit: (https://github.com/opentibiabr/canary/commit/9c257da) Set for use name of the item instead of id in the ShopInfoMap vector This will allow adding items with the same item ids and customizing the item name Fixed somes npcs shop bugs
[Source]: ConfigManager - fix (#208) typo from "freeQuests" to "toggleFreeQuest" (author: @dudantas, commit: 0c08898)
[Source]: Added new method ```vocation:getBaseAttackSpeed```` for offline training and exercise training script (author: @Rechdan, commit: (https://github.com/opentibiabr/canary/commit/8315cf5)
[Source]: Added new Lua method configManager.getFloat (author: @Rechdan, commit: (https://github.com/opentibiabr/canary/commit/2811015) Fix nil value in the offline training and exercise training script
[Source]: Fix support rates regen, removed multiplication and modified to use getBaseAttackSpeed instead of getAttackSpeed (author: @dudantas, commit: (https://github.com/opentibiabr/canary/commit/29846fa)
[Source]: Set item tier bytes from "0" to "1" from protocol 12.85 (author: @dudantas, commit: (https://github.com/opentibiabr/canary/commit/cc98f40) Modified item tier byte to be 1 by default. Added one static_cast<uint8_t> in the function "item->getImbuementSlot()", for resolve review check from CodeQL.

OTServBR-Global Modifications

Modified (Global):

[Lua]: NPC's Revscriptsys - Fix lookTypeEx typo and convert to clientId (author: @daanyx, commit: 2cc1a6db1) Fixed bug in "lookTypeex" variable to "lookTypeEx" and converted ids to clientId.
[Lua/Pack]: Protocol 12.85 - Support for client version 12.85 datapack (author: @marcosvf132, commit: a29bc41c1) Protocol 12.85 datapack Syncronize datapack with Canary 12.85 commit: https://github.com/opentibiabr/canary/commit/e9c85a5a0893981d57af30d979a23d259734119c Small fix on the "loadLuaMapAction" function that was breaking the map loading by LUA. The changes on this commit is following the same changes on the pull request :https://github.com/opentibiabr/canary/pull/203

Fixed problems (Global):

[Lua]: NPC's Revscriptsys - Fixed the bug in the shops of npcs that have the same item for sell and buy (author: @dudantas, commit: c1eb738e4) The way the shop was converted doesn't work to have two tables separating the "sell" and the "buy", it needs to be in a single table, thus preventing the same item from appearing in the sell and not appearing in the buy. I took advantage of the pull request to move the functions to the correct locations, thus getting more organized. Fixed others bugs related to the npcs
[Lua]: Fix addEvent from grimvale quest calling nil function (author: @dudantas, commit: c20b80048)
[Lua]: Change flag from "pet" tag for "familiar", fix the bug where the summon doesn't enter pz (author: @dudantas, commit: 38bbf2d67)
[Lua]: Fix lower/upper case in the unscripted_equipments and unscripted_weapons (author: @dudantas, commit: 8a7e8e3ad)
[Lua]: Convert id from magic gold converter to client id (author: @painer15999, commit: a4a024d77)
[Lua]: Fix lion shield on unscripted equipments table (author: @painer15999, commit: 767f9e05a)

stable-v1.1.1

2 years ago

Support client 12.72.11206 and otclient (pull in progress)

Global datapack lua code: https://github.com/opentibiabr/otservbr-global/commit/e4524f8fa006b7d14e801413de64c7d09df23423 Canary source code: https://github.com/opentibiabr/canary/commit/6388163d28d54878335e3c9ee33c008ddf587b2f)

Adjusted:

Interval that npcs send messages in the default chat,
Speed that npcs walk (baseSpeed),
Interval of steps of npcs to 2 seconds (walkInterval),
Fixed a small bug in the npc shop that prevented items from appearing in the trade in certain scenarios.

stable-v1.1.0

2 years ago

Support client 12.72.11206 and otclient (pull in progress)

Description: NPCS converted to revscriptsys and removed the npcs xml Changed jiddo lib to work with revscriptsys npcs, also making several improvements to the lib. And several other functions that have been improved or rework. We also removed all the code from the lib that parse/handle the npcs xml.

Module shop has been removed (a big improvement was made where the shop is now in npcType, more easily and is called directly from source).

Added back storage of npcs spawns in the world folder (there was also a reorganization, where npcs and monsters will be in separate files from now on, as it will be possible to see npcs on the map).

Several other modifications and adaptations to make compatibility possible.

NOTE: This commit (1ffd9f109) will work directly with the commit: https://github.com/opentibiabr/canary/commit/0397d0c97e6191d1a64503970d21657eeb2f8886, from Canary repository. After this commit, the OTServBR-Global will use the Canary Engine, there will no longer be source code in global. Thanks for @dudantas, @lgrossi, @gpedro, @Beats-Dh, @omeranha, @dmarszk.

Modifications

Added:

Npclib:

Callbacks:

onCloseChannel (CALLBACK_ON_CLOSE_CHANNEL)
onMove (CALLBACK_ON_MOVE)
FocusModule.tradeCallback
NpcsEvent_t enum: NPCS_EVENT_PLAYER_CLOSE_CHANNEL

Lua functions:

NpcHandler:getKeywordHandler()
NpcHandler:getEventDelayedSay(playerId)
NpcHandler:setEventDelayedSay(playerId, newEventDelayedSay)
NpcHandler:getEventSay(playerId)
NpcHandler:setEventSay(playerId, newEventSay)
NpcHandler:getTalkStart(playerId)
NpcHandler:setTalkStart(playerId, newTalkStart)
NpcHandler:getTopic(playerId)
NpcHandler:setTopic(playerId, newTopic)
NpcHandler:checkInteraction(npc, player)
NpcHandler:updateInteraction(npc, player)
NpcHandler:setInteraction(npc, player)
NpcHandler:removeInteraction(npc, player)
NpcHandler:tradeRequest(npc, player, message)
NpcHandler:onMove(npc, player, fromPosition, toPosition)
NpcHandler:sendMessages(message, messageTable, npc, player, useDelay, delay)
FocusModule:setTradeCallback(callback)
Npc:sayWithDelay(npcId, text, messageType, delay, event, playerId)
Npc:sendMessage(player, text)
Npc:isMerchant()
Npc:closeShopWindow(player)
Npc:isInTalkRange(playerPosition)
Npc:move(direction)
Npc:turn(direction)
Npc:follow(player)
Npc:getId()
Npc:sellItem(player, itemid, amount, subtype, actionid, <optional: default: 1> canDropOnMap)
Npc:getDistanceTo(uid)
NpcType:getSpeechBubble()
NpcType:setSpeechBubble()
Player:getItemIdByCid(itemId)
Item:getClientId()
LuaFunctionsLoader::getErrorDesc(ErrorCode_t code) new callback: LUA_ERROR_NPC_TYPE_NOT_FOUND

Cpp functions:

Npc::onPlayerCloseChannel(creature)
Game::loadCustomMap(name)
Iomap: loadMonstersCustom(map), loadNpcsCustom(map), loadHousesCustom(map)

Cpp definitions:

ITEM_FILLED_BATH_TUBE, ITEM_SWORD_RING, ITEM_CLUB_RING, ITEM_DWARVEN_RING, ITEM_RING_HEALING, ITEM_STEALTH_RING, ITEM_TIME_RING, ITEM_PAIR_SOFT_BOOTS, ITEM_PAIR_SOFT_BOOTS_ACTIVATED, ITEM_DEATH_RING, ITEM_DEATH_RING_ACTIVATED, ITEM_PRISMATIC_RING, ITEM_PRISMATIC_RING_ACTIVATED.

Othes:

Added bank system lib (bank_system.lua)
TalkAction: /addmoney playername, moneycount

Modified

Callbacks:

FROM: CALLBACK_CREATURE_APPEAR, TO: CALLBACK_ON_APPEAR
FROM: CALLBACK_CREATURE_DISAPPEAR, TO: CALLBACK_ON_DISAPPEAR
FROM: CALLBACK_CREATURE_SAY, TO: CALLBACK_ON_SAY
FROM: CALLBACK_ONTHINK, TO: CALLBACK_ON_THINK
FROM: CALLBACK_PLAYER_ENDTRADE, TO: CALLBACK_PLAYER_END_TRADE
FROM: CALLBACK_PLAYER_CLOSECHANNEL, TO: CALLBACK_CLOSE_CHANNEL
FROM: CALLBACK_ONADDFOCUS, TO: CALLBACK_SET_INTERACTION
FROM: CALLBACK_ONRELEASEFOCUS, TO: CALLBACK_REMOVE_INTERACTION
FROM: CALLBACK_ONTRADEREQUEST, TO: CALLBACK_ON_TRADE_REQUEST
FROM: SHOP_TRADEREQUEST, TO: FOCUS_TRADE_MESSAGE

Functions:

From: player:removeMoneyNpc(), to: player:removeMoneyBank(cost)
From: NpcHandler.eventSay[focus] = nil, to: NpcHandler:setEventSay(playerId, nil)
From: NpcHandler.eventDelayedSay[focus] = nil, to: NpcHandler:setEventDelayedSay(playerId, nil)
From: NpcHandler.talkStart[focus] = nil, to: NpcHandler:setTalkStart(playerId, nil)
From: NpcHandler.topic[focus] = nil, to: NpcHandler:setTopic(playerId, nil)
From: NpcHandler:onCreatureAppear, to: NpcHandler:onAppear
From: NpcHandler:onCreatureDisappear, to: NpcHandler:onDisappear
From: NpcHandler:onCreatureAppear, to: NpcHandler:onAppear
From: NpcHandler:onCreatureSay, to: NpcHandler:onSay
From: NpcHandler:onPlayerCloseChannel, to: NpcHandler:onCloseChannel
From: NpcHandler.topic[playerId] = topicId, to: NpcHandler:setTopic(playerId, topicId)
From: NpcHandler.topic[playerId] == topicId, to: NpcHandler:getTopic(playerId) == topicId
From: Charm:cancelMessage(), to: charm:messageCancel()
From: Charm:logMsg(), to: Charm:messageServerLog()
msgcontains(message, keyword) = It was refactored so that it identifies the entire string and does not read just one word, generating this issue: https://github.com/opentibiabr/otservbr-global/issues/2736

Removed

Npclib:

Callbacks:

NpcHandler: focuses, idleTime, talkRadius, shopItems, MESSAGE_ONBUY, MESSAGE_BOUGHT, MESSAGE_SELL, MESSAGE_ONSELL, MESSAGE_SOLD, MESSAGE_IDLETIMEOUT
Voice modules
Shop module
NpcSystem (It was used to parse XML npcs information)

Lua functions:

NpcHandler:isFocused
NpcHandler:releaseFocus
NpcHandler:onPlayerEndTrade
NpcHandler:onSell
doNpcSellItem
doCreatureSayWithDelay
doPlayerSellItem
doPlayerBuyItemContainer
doPlayerRemoveMoney
getPlayerMoney
closeShopWindow

Cpp functions:

Npc:getCurrencyTrading()

Others modifications:

Changed configkey = From: MAP_CUSTOM_ENABLED, to: TOGGLE_MAP_CUSTOM
Fixed the load of the custom map, which is now directly in the source and works as a complement to the main map.
Removed ConfigKey: MAP_CUSTOM_FILE and MAP_CUSTOM_SPAWN
Some functions are capitalized to indicate that they are global functions, for example: MessageContains(), GetCount(), and others.
Rework on bestiary_charm script

stable-v1.0.6

2 years ago

Support client 12.72.11206 and otclient (pull in progress)

Fixed:

Free quest system (author: @dudantas and @Beats-Dh, commits: 5a722dc7c, d405eae37)

Note: this will be the last release where the global repository will be sourced. The next one, which will be release 1.1.0, will be sourced from Engine Canary.

stable-v1.0.5

2 years ago

Support client 12.72.11206 and otclient (pull in progress)

Modified:

[Source/Lua] Create familiars lib, rename from "pet" to "familiar" and others fixes (author: @dudantas, commit: e34e40140) Fixes: Rename from "pet/Pet" to "familiar/Familiar" Removed "familiar = false" from monsters, this is false by default (this change is optional) Renamed from "mtype:isPet" to "mtype:familiar" Fixed familiar login with god. Co-authored-by: @Beats-Dh
[Lua] Register missing foods "goanna meat" and "candy floss" (author: @travisani, commit: 0cb8387e8)

Fixed problems:

[Source] Fix double remove money on create market offer (author: @dudantas, commit: 3228c9ecd)
[Source] Fix remove item from stash on apply imbuement (author: @dudantas, commit: 962e323c3) The function "getStashItemCount" uses client id instead of id.
[Source] Fixed crash after conjure item with duration (author: @dudantas, commit: 73d4d1034) Fixed crash after casting item with duration Fixed "register_spells.lua" indentation Added nullpointer on the load backpacks function
[Lua] Removed creature events from monsters script interface (author: @dudantas, commit: 5f004ad18) Scripts cannot be placed inside the monsters folder, as it is the monsters only interface, all other types of scripts need to be in the scripts folder.
[Lua/XML] Removed duplication in events and rearranged the xml order (author: @gpedro, commit: 44d75fe11)
[Lua/XML] Amulet bug fix in enchanted werewolf amulet time and skill (author: @painer15999, commit: 02e6f32ec) Amulet bug fix in enchanted werewolf amulet time result (onDeEquip) and skill bug
[Source] Fix wrong increment equipment skills in "onEquip/deEquip" (author: @Rechdan, commit: 02e88a1cd) Added item->hasAttribute(ITEM_ATTRIBUTE_DURATION) to check if the item has the duration attribute, making it so that only items that are in the decay stage can enter the if With the PR #375 a bug with weapons that have skills was introduced, where they started to remove the skill instead of adding it, this PR is to fix that.
[Lua] Fix freezing freequests.lua (author: beats-dh, commit: d02379969)
[Lua/Source], Fix issue #380 and #389, fix maxSummons bug (author: @dudantas, commit: 62d734858) Variable "monster.summons" renamed to "monster.summon" Improved the "registerMonsterType.summon" function. The "monster.maxSummons" was changed to be inside "monster.summon", thus facilitating development Added new table "summons" inside of "monster.summon" Added the "count" in the "monsterType:addSummon" function Fixed somes summons with "Demon2" name to "Demon" Removed "monster.summonCost", the correct is "monster.manaCost" Fixed a bug in the "registerMonsterType.light" function Fixed bug in the familiar behavior Modified all monsters for new style of summons
[Lua] Fix message "log out more than 10 minutes to start offline training" (author: @travisani, commit: 2a2221246) Message like tibia global
[Lua] Fix message and min level for talk in "advertising" and "english chat" (author: @travisani, commit: c6cc888f6) Same behavior as in global tibia, so the requirement will be at least level 20 or have a premium account. In addition to fixed the message.
[Lua] Fix lion's rock quest "holy water fountain" and "fountain rewards" (author: @EeFo17, commit: 762188b9c)
[Source] Fix removing items from stash on apply imbuement (author: @dudantas, commit: bc92e3ca0) Complement of the pr: #373
[Source/Lua] Fix issues #312, #399, fix bestiary counter logic and update charm values (author: @marcosvf132, commit: e96951dab)

stable-v1.0.1

2 years ago

Support to client 12.72.11206 (author:marcosvf132, commit: 20866ec6) and otclient (pull in progress)

Modified:

[Source] Fixed imbuement system behavior and a crash related to memory reference (author @hyresu, commit: 6f4fddb8) • Fixed: Item only gets inmediate bonus when imbued on equipment slots Clearing the imbuement will make you lose it if the item is equipped You should be able to use bank balance for imbuements Elemental damage shouldn't be affected Critical hit chance should not get higher than 10% if the item already has critical hit chance Falcon Coif should be able to get Intricate Epiphany and Dark Whispers only Basic Epiphany Item description should show crit chance without positive sign and "critical extra damage" Move map deletion to outside the loop to avoid memory reference crash on Game::checkImbuements function • Enhancement: Where the "imbuementslot" value is from 1 to 3 and the imbuement name values are also from 1 to 3, which is the imbuement level (basic, intricate or powerful), the name must be placed as above, as it is from the name that the value of each imbuement is called by ItemNode.

Fixed problems:

[Lua] Fix issue #287, hirelings sell function don't work (author: @gpedro, commit: 5c167903)
[Lua] Fix issue #332, familiars script does not make sure if the player has a vocation (author: @gpedro, commit: 49596a2e)
[Lua] Fix issue #309, wrong toKill value for star 3 on bestiary (author: @gpedro, commit: 79955d92)