Cloudposse Terraform Aws Rds Versions Save

what

• fix: use try on length(var.subnets)

why

• If the length is used without a try, if subnets are not passed in, the module will fail
• The use case is when the rds component is deployed with enabled = false, it relies on the vpc component which may not be deployed yet. So the enabled: false flag is used for both the vpc and rds, however rds will still try to retrieve from the remote state vpc which will try to pass in a null list of subnets which causes this failure
• A local plan against this branch results in the correct plan

references

N/A

what

• Update workflows (.github/workflows/settings.yaml)

why

• Support new readme generation workflow.
• Generate banners

what

The default value of the iops variable is changed from 0 to null.

why

Resolves an issue with gp3 storage type when allocated storage is below 400 GB. This shouldn't cause problems in other cases, as the parameter is optional at the provider level.

references

• closes #168
• official docs on iops parameter

what

• Install latest GitHub Action Workflows

why

• Use shared workflows from cldouposse/.github repository
• Simplify management of workflows from centralized hub of configuration

what

• Install a repository config (.github/settings.yaml)

why

• Programmatically manage GitHub repo settings

what

• Reran make readme to rebuild README.md from README.yaml
• Migrate to square badges
• Add scaffolding for repo settings and Mergify

why

• Upstream template changed in the .github repo
• Work better with repository rulesets
• Modernize look & feel

what

• Allow specifying the required configuration to create a database instance via the point-in-time-recovery process
• Update variable description for snapshot_identifier

why

• Support an alternative creation/DR scenario

references

None

what

• Updates README to latest

why

• README changes are blocking release https://github.com/cloudposse/terraform-aws-rds/pull/157

references

• https://github.com/cloudposse/terraform-aws-rds/pull/157
• Broken release: https://github.com/cloudposse/terraform-aws-rds/actions/runs/6870446258

what

• add parameter manage_master_user_password
• add parameter master_user_secret_kms_key_id

why

• allow use new feature

references

• https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#managed-master-passwords-via-secrets-manager-specific-kms-key
• https://github.com/hashicorp/terraform-provider-aws/blob/v4.61.0/CHANGELOG.md

This PR contains the following updates:

Release Notes

what

• Support AWS Provider V5

  • Notable: ID output breaking (in regards to provider version compatibility) change https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-5-upgrade#resourceaws_db_instance

• Linter fixes

why

Maintenance

references

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

Rebuild github dir from the template

what

• Fix issue https://github.com/cloudposse/terraform-aws-rds/issues/154 .

Fix description for engine_version parameter. Delete this sentence for engine_version:

Required unless a snapshot_identifier or replicate_source_db is provided.

why

• According to the official documentation (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#engine_version), there is no mentioning that it doesn't need to specify engine_version when you specified snapshot_identifier.

references

• https://github.com/cloudposse/terraform-aws-rds/issues/154

what

• Add storage_throughput option, as described in the provider

why

• Need this for gp3 storage types if not using the default for your given allocated_storage

references

• https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#storage_throughput

what

• Update AWS provider to 4.49.0 (latest) to support gp3 as storage type on RDS instances

why

• gp3 storage type is up to 20% cheaper than gp2 and iops or throughput doesn't depend on the volume size.

references

• This is a recent enhancement from AWS for RDS instances: https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-rds-general-purpose-gp3-storage-volumes/
• EBS AWS docs: https://aws.amazon.com/ebs/general-purpose/

what

• added timeouts variable (object) to the variables.tf file
• added timeouts code block that references the var.timeouts.x variable with default values to the aws_db_instance resource in main.tf
• added variable description in the README.md

why

I ran into an issue where using the module in TF Cloud during creation the run times out. The instance get's created but due to the run timing out the TF Cloud state does not get updated and each subsequent run would tear down an instance and recreate it, timing out once again. I added a timeouts variable with default terraform values, which a user can change if they desire in order to accommodate a longer run.